feat(IT Wallet): [SIW-560] Generalize loading component #5055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagopa-github-bot
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## bundle/it-wallet #5055 +/- ##
====================================================
+ Coverage 46.42% 46.48% +0.06%
====================================================
Files 1583 1584 +1
Lines 32906 32855 -51
Branches 8305 8176 -129
====================================================
- Hits 15275 15273 -2
+ Misses 17568 17527 -41
+ Partials 63 55 -8
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
LazyAfternoons
added a commit
that referenced
this pull request
Oct 4, 2023
## Short description This PR proposes a generalization of the `ItwLoadingSpinner`. ## List of changes proposed in this pull request - Adds an optional `size` prop which defaults to `24` to render the spinner component in different sizes. `76` is kept for backward compatibility with the existing screens and will be removed after we migrate completely to the new design system. - Makes the `color` prop optional which defaults to `IOColors["blueIO-500"]` for the new design system; - Removes `captionTitle` and `captionSubtitle` from the loading spinner component and moves it to `ItwLoadingSpinnerOverlay.tsx` which is also updated with the new design system. ## How to test Test an issuing flow and check for any regression. Please note that the "legacy" spinner might be a little thinner than before. Also, this is still not updated with the new gradient style. --------- Co-authored-by: Mario Perrotta <mario.perrotta@pagopa.it>
dmnplb
added a commit
to pagopa/io-app-design-system
that referenced
this pull request
Oct 9, 2023
## Short description This PR adds the new `LoadingSpinner` component, derived from `ItwLoadingSpinner` developed specifically for the IT Wallet flow. To learn more about the original component: * pagopa/io-app#5055 ## List of changes proposed in this pull request - Slightly refactor the original component - Add the new **Loaders** page to the example app ### Preview https://github.com/pagopa/io-app-design-system/assets/1255491/fa506c48-eea3-4210-854c-b5fe66ba5132 ## How to test 1. Launch the example app 2. Go to the **Loaders** page --------- Co-authored-by: Cristiano Tofani <cri.tofani@gmail.com>
LazyAfternoons
added a commit
that referenced
this pull request
Nov 20, 2023
## Short description This PR proposes a generalization of the `ItwLoadingSpinner`. ## List of changes proposed in this pull request - Adds an optional `size` prop which defaults to `24` to render the spinner component in different sizes. `76` is kept for backward compatibility with the existing screens and will be removed after we migrate completely to the new design system. - Makes the `color` prop optional which defaults to `IOColors["blueIO-500"]` for the new design system; - Removes `captionTitle` and `captionSubtitle` from the loading spinner component and moves it to `ItwLoadingSpinnerOverlay.tsx` which is also updated with the new design system. ## How to test Test an issuing flow and check for any regression. Please note that the "legacy" spinner might be a little thinner than before. Also, this is still not updated with the new gradient style. --------- Co-authored-by: Mario Perrotta <mario.perrotta@pagopa.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR proposes a generalization of the
ItwLoadingSpinner.List of changes proposed in this pull request
sizeprop which defaults to24to render the spinner component in different sizes.76is kept for backward compatibility with the existing screens and will be removed after we migrate completely to the new design system.colorprop optional which defaults toIOColors["blueIO-500"]for the new design system;captionTitleandcaptionSubtitlefrom the loading spinner component and moves it toItwLoadingSpinnerOverlay.tsxwhich is also updated with the new design system.How to test
Test an issuing flow and check for any regression. Please note that the "legacy" spinner might be a little thinner than before. Also, this is still not updated with the new gradient style.