Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(IT Wallet): [SIW-580] Update loading screen typography #5144

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

LazyAfternoons
Copy link
Contributor

@LazyAfternoons LazyAfternoons commented Oct 19, 2023

Short description

This PR updates the typography in the ItwLoadingSpinnerOverlay.tsx according to the FIGMA.

Before After

List of changes proposed in this pull request

  • Replaces H2 with H3;
  • Replaces H4 with body.

How to test

Check if the new style is properly applied in loading screens of any ITW related flow.

@LazyAfternoons LazyAfternoons temporarily deployed to dev October 19, 2023 14:01 — with GitHub Actions Inactive
@pagopa-github-bot pagopa-github-bot changed the title [SIW-580] Update loading screen typography chore(IT Wallet): [SIW-580] Update loading screen typography Oct 19, 2023
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 19, 2023

Affected stories

  • ⚙️ SIW-580: [APP] Aggiornare il loading component overlay con i nuovi header e body

Generated by 🚫 dangerJS against f8ef2ee

@LazyAfternoons LazyAfternoons marked this pull request as ready for review October 19, 2023 14:03
@LazyAfternoons LazyAfternoons requested a review from a team as a code owner October 19, 2023 14:03
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #5144 (564a17c) into bundle/it-wallet (308461f) will decrease coverage by 0.49%.
Report is 220 commits behind head on bundle/it-wallet.
The diff coverage is 29.35%.

❗ Current head 564a17c differs from pull request most recent head f8ef2ee. Consider uploading reports for the commit f8ef2ee to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           bundle/it-wallet    #5144      +/-   ##
====================================================
- Coverage             46.42%   45.93%   -0.49%     
====================================================
  Files                  1583     1611      +28     
  Lines                 32906    33138     +232     
  Branches               8305     8303       -2     
====================================================
- Hits                  15275    15223      -52     
- Misses                17568    17859     +291     
+ Partials                 63       56       -7     
Files Coverage Δ
scripts/ts/danger/utils/changelog.ts 70.49% <ø> (ø)
ts/components/ContextualInfo.tsx 81.81% <ø> (ø)
ts/components/ForceScrollDownView.tsx 75.67% <ø> (ø)
ts/components/GoBackButton.tsx 90.00% <ø> (ø)
ts/components/RemindEmailValidationOverlay.tsx 7.75% <ø> (ø)
ts/components/bottomSheet/BottomSheetHeader.tsx 13.33% <ø> (ø)
ts/components/core/fonts.ts 95.00% <ø> (ø)
...s/components/screens/BaseScreenComponent/index.tsx 70.83% <ø> (ø)
ts/components/screens/DarkLayout.tsx 5.26% <ø> (ø)
ts/components/screens/TopScreenComponent.tsx 100.00% <ø> (ø)
... and 109 more

... and 90 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2643804...f8ef2ee. Read the comment docs.

@hevelius hevelius temporarily deployed to dev October 19, 2023 23:50 — with GitHub Actions Inactive
Copy link
Contributor

@hevelius hevelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LazyAfternoons LazyAfternoons merged commit 6763ee0 into bundle/it-wallet Oct 20, 2023
4 checks passed
@LazyAfternoons LazyAfternoons deleted the SIW-580-loading-screen-typography branch October 20, 2023 14:41
LazyAfternoons added a commit that referenced this pull request Nov 20, 2023
## Short description
This PR updates the typography in the `ItwLoadingSpinnerOverlay.tsx`
according to the FIGMA.

| Before | After |
|--------|--------|
| <img
src="https://github.com/pagopa/io-app/assets/12371664/8f1df6c5-d285-44be-8b5a-d05f08fcc1f9"
height="400"> | <img
src="https://github.com/pagopa/io-app/assets/12371664/815680ef-47bb-4890-be7a-cabd23398aa6"
height="400"> |

## List of changes proposed in this pull request
- Replaces `H2` with `H3`;
- Replaces `H4` with `body`.

## How to test
Check if the new style is properly applied in loading screens of any ITW
related flow.

Co-authored-by: Mario Perrotta <mario.perrotta@pagopa.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants