chore(IT Wallet): [SIW-624] Add navigation to missing feature screen #5228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagopa-github-bot
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## bundle/it-wallet #5228 +/- ##
====================================================
- Coverage 46.42% 45.65% -0.78%
====================================================
Files 1583 1619 +36
Lines 32906 33437 +531
Branches 8305 8245 -60
====================================================
- Hits 15275 15264 -11
- Misses 17568 18124 +556
+ Partials 63 49 -14
... and 109 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
hevelius
reviewed
Nov 16, 2023
Yes, that slipped away, thank you. Done in 589013c. |
LazyAfternoons
added a commit
that referenced
this pull request
Nov 20, 2023
…5228) ## Short description This PR adds a navigation to the missing feature screen where a feature is not implemented yet. ## List of changes proposed in this pull request - Adds the navigation in [ItwCredentialDetailsScreen.tsx](https://github.com/pagopa/io-app/pull/5228/files#diff-94e935f2d7d760954fd0c0647b59f32cd163d70dac988b5588a985aadef0689b) when pressing the `Show QR Code` button and the banner; - Adds the navigation in [ItwPidDetails.tsx](https://github.com/pagopa/io-app/pull/5228/files#diff-94e935f2d7d760954fd0c0647b59f32cd163d70dac988b5588a985aadef0689b) on the `Show QR Code` button and when tapping on the security level; - Adds the navigation in [ts/features/it-wallet/screens/issuing/ItwPidPreviewScreen.tsx](https://github.com/pagopa/io-app/pull/5228/files#diff-1efa65eedbb4bea4a8d61f1d909912fa8a94af60a4df438f01730c624c2c9fca) when tapping on the security level. ## How to test Check if the navigation happens properly in the aformentioned screens. Also check if there's any other unresponsive pressable element in any ITW related flow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds a navigation to the missing feature screen where a feature is not implemented yet.
List of changes proposed in this pull request
Show QR Codebutton and the banner;Show QR Codebutton and when tapping on the security level;How to test
Check if the navigation happens properly in the aformentioned screens. Also check if there's any other unresponsive pressable element in any ITW related flow.