Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(IT Wallet): [SIW-783] Update io-react-native-proximity to version 0.1.7 #5362

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

hevelius
Copy link
Contributor

Short description

This PR updates io-react-native-proximity to version 0.1.7

List of changes proposed in this pull request

  • Update package.json

How to test

Static checks should be enough

@hevelius hevelius changed the title [SIW-783] Update ìo-react-native-proximity to version 0.1.7` [SIW-783] Update io-react-native-proximity to version 0.1.7 Dec 21, 2023
@hevelius hevelius marked this pull request as ready for review December 21, 2023 10:57
@hevelius hevelius requested a review from a team as a code owner December 21, 2023 10:57
@pagopa-github-bot pagopa-github-bot changed the title [SIW-783] Update io-react-native-proximity to version 0.1.7 chore(IT Wallet): [SIW-783] Update io-react-native-proximity to version 0.1.7 Dec 21, 2023
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Dec 21, 2023

Affected stories

  • ⚙️ SIW-783: [APP] Aggiornare la versione di io-react-native-proximity su it-wallet alla 0.1.7

Generated by 🚫 dangerJS against f31b3be

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (843b4b7) 46.36% compared to head (f31b3be) 46.33%.
Report is 5 commits behind head on bundle/it-wallet.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           bundle/it-wallet    #5362      +/-   ##
====================================================
- Coverage             46.36%   46.33%   -0.04%     
====================================================
  Files                  1638     1641       +3     
  Lines                 34010    34068      +58     
  Branches               8245     8254       +9     
====================================================
+ Hits                  15769    15785      +16     
- Misses                18190    18232      +42     
  Partials                 51       51              
Files Coverage Δ
...res/it-wallet/store/actions/itwProximityActions.ts 100.00% <100.00%> (ø)
ts/features/it-wallet/store/reducers/index.ts 66.66% <ø> (ø)
ts/features/it-wallet/utils/itwErrorsUtils.ts 50.00% <ø> (ø)
ts/features/it-wallet/saga/index.ts 0.00% <0.00%> (ø)
...es/it-wallet/store/reducers/itwProximityReducer.ts 37.03% <37.03%> (ø)
ts/features/it-wallet/saga/itwProximitySaga.ts 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20080b1...f31b3be. Read the comment docs.

Copy link
Contributor

@LazyAfternoons LazyAfternoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hevelius hevelius merged commit 4858220 into bundle/it-wallet Dec 21, 2023
6 checks passed
@hevelius hevelius deleted the SIW-783-update-proximity-version branch December 21, 2023 11:13
hevelius added a commit that referenced this pull request Dec 22, 2023
…proximity saga (#5361)

### This PR depends on #5362 

## Short description
Include a summary of the changes.

## List of changes proposed in this pull request
- Update ItwPrProximityQrCodeScreen
- Add mocked mDL response

## How to test
Start the app. After wallet activation try to request a credential like
the mDL. Go to the credential detail and tap on "Show QR Code". Using a
verifier app Scan te QR Code to start proximity flow. The credential
should be correctly verified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants