Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOPAE-1142] Added featured carousels in ServicesHomeScreen #5793

Merged
merged 2 commits into from
May 23, 2024

Conversation

adelloste
Copy link
Member

Short description

This PR refactors the ServicesHomeScreen screen by adding the featured services and the featured institutions carousels.

Details

New services tab
new-services-tab.mp4

List of changes proposed in this pull request

  • Added CardPressableBase component
  • Updated carousels by adding the CardPressableBase component
  • Updated ServicesHomeScreen screen to display the national institutions and featured carousels
  • Updated locales

How to test

Using io-dev-api-server, navigate to the services tab. Check that the screen is displayed correctly

@adelloste adelloste added the IO-Enti e Servizi IO - Enti e Servizi label May 23, 2024
@adelloste adelloste requested review from thisisjp and a team as code owners May 23, 2024 11:15
@pagopa-github-bot pagopa-github-bot changed the title [IOPAE-1142] Added featured carousels in ServicesHomeScreen chore: [IOPAE-1142] Added featured carousels in ServicesHomeScreen May 23, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented May 23, 2024

Affected stories

  • ⚙️ IOPAE-1142: [IO-APP] Sviluppo sezione con carosello enti e carosello servizi in evidenza
    subtask of
    • 🌟 IOPAE-1135: [Rework] Enti & Servizi in evidenza su App IO

Generated by 🚫 dangerJS against c2da4ad

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 20.33898% with 94 lines in your changes are missing coverage. Please review.

Project coverage is 49.53%. Comparing base (4f204b4) to head (c2da4ad).
Report is 97 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5793      +/-   ##
==========================================
+ Coverage   48.42%   49.53%   +1.11%     
==========================================
  Files        1488     1625     +137     
  Lines       31617    32248     +631     
  Branches     7669     7864     +195     
==========================================
+ Hits        15311    15975     +664     
+ Misses      16238    16210      -28     
+ Partials       68       63       -5     
Files Coverage Δ
...s/services/common/components/CardPressableBase.tsx 100.00% <100.00%> (ø)
...rvices/home/components/FeaturedInstitutionCard.tsx 90.00% <100.00%> (ø)
ts/features/services/home/store/reducers/index.ts 97.10% <100.00%> (ø)
...s/services/home/components/FeaturedServiceCard.tsx 86.66% <87.50%> (ø)
...ices/common/components/InstitutionListSkeleton.tsx 28.57% <20.00%> (ø)
...res/services/home/hooks/useInstitutionsFetcher.tsx 7.69% <0.00%> (ø)
...rvices/home/components/FeaturedInstitutionList.tsx 4.76% <4.76%> (ø)
...s/services/home/components/FeaturedServiceList.tsx 4.76% <4.76%> (ø)
...tures/services/home/screens/ServicesHomeScreen.tsx 5.71% <5.71%> (ø)

... and 525 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bfb1d2...c2da4ad. Read the comment docs.

Copy link
Contributor

@giuseppedipinto giuseppedipinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! 🎯🚀

@adelloste adelloste merged commit ca2de78 into master May 23, 2024
13 checks passed
@adelloste adelloste deleted the IOPAE-1142-services-home-featured branch May 23, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Enti e Servizi IO - Enti e Servizi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants