Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import URL on postMessage script to send slack message on release completed #5952

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

CrisTofani
Copy link
Contributor

Short description

Minor fix to restore message on release completed to slack channel

How to test

Latest message was sent from local env

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jul 10, 2024

Warnings
⚠️ Please include a Jira ticket at the beginning of the PR title

Example of PR titles that include Jira tickets:

  • single story: [PROJID-123] my PR title
  • multiple stories: [PROJID-1,PROJID-2,PROJID-3] my PR title

Generated by 🚫 dangerJS against 4ba4b8b

Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.02%. Comparing base (4f204b4) to head (4ba4b8b).
Report is 261 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5952      +/-   ##
==========================================
+ Coverage   48.42%   49.02%   +0.59%     
==========================================
  Files        1488     1714     +226     
  Lines       31617    34297    +2680     
  Branches     7669     8366     +697     
==========================================
+ Hits        15311    16814    +1503     
- Misses      16238    17427    +1189     
+ Partials       68       56      -12     

see 1022 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1688cc9...4ba4b8b. Read the comment docs.

@CrisTofani CrisTofani merged commit a3bc4c4 into master Jul 10, 2024
13 checks passed
@CrisTofani CrisTofani deleted the fix-post-release-message branch July 10, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants