Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross): [IOAPPX-343,IOAPPX-311] Add react-native-skia library + Dynamic header background (under the new Experimental Lab category) #5954

Merged

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Jul 10, 2024

Short description

This PR adds the latest version of the react-native-skia library and the new Experimental Lab section which includes the new Dynamic header background screen, built with the skia library

List of changes proposed in this pull request

  • Add the react-native-skia library
  • Update jest config files to include react-native-skia references
  • Add the new Experimental Lab section
  • Add the new Dynamic header background as first experiment

Preview

dynamic-background.1.mp4

Acknowledgement

We've successfully added this library thanks to the RN upgrade to the 0.72 version:

How to test

  1. Launch the app in the local environment
  2. Go to the Experimental LabDynamic header background

LazyAfternoons and others added 30 commits January 19, 2024 22:12
Co-authored-by: Cristiano Tofani <cri.tofani@gmail.com>
Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmnplb dmnplb merged commit 9170ebb into master Aug 8, 2024
13 checks passed
@dmnplb dmnplb deleted the IOAPPX-343-311-add-skia-add-dynamic-background-with-skia branch August 8, 2024 07:45
Vangaorth added a commit that referenced this pull request Aug 8, 2024
… + Dynamic header background (under the new Experimental Lab category)" (#6103)

Reverts #5954
dmnplb added a commit that referenced this pull request Oct 1, 2024
… + Dynamic header background (under the new Experimental Lab category) (#6123)

> [!caution]
> Due to the coexistence of two different versions of `XState`, this PR
depends on:
> * #6135

This PR restores the original PR, already approved. Read the description
to learn more:
* #5954

---------

Co-authored-by: Andrea <andrea.piai@pagopa.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code review needed 💻📱 Insert this label if you need a code review that no one in your team can give you Cross Design System New visual language and reduction of previous UI clutter Experimental lab ✨ Interface experiments that may never see the light of the day
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants