Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross): [IOAPPX-358] Updates io-app-design-system for accessibility improvements #6064

Merged
merged 20 commits into from
Aug 2, 2024

Conversation

CrisTofani
Copy link
Contributor

@CrisTofani CrisTofani commented Jul 29, 2024

Short description

This PR upgrade the ds library to gain all the accessibility improvements made by the high priority activities highlighted from the first external assessment.

List of changes proposed in this pull request

  • Except from improvements coming from the library now all the validation inputs require a mandatory errorMessage

How to test

Check the error message are properly set by the related content on each section.

@pagopa-github-bot pagopa-github-bot changed the title [IOAPPX-358] Updates io-app-design-system for accessibility alignment chore(Cross): [IOAPPX-358] Updates io-app-design-system for accessibility alignment Jul 29, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jul 29, 2024

Affected stories

  • ⚙️ IOAPPX-358: Aggiornamento della librearia di design system per supportare le modifiche di accessibilità

Generated by 🚫 dangerJS against ce65bb4

Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for A&I

@dmnplb dmnplb added the a11y Activities related to accessibility label Jul 29, 2024
@dmnplb dmnplb changed the title chore(Cross): [IOAPPX-358] Updates io-app-design-system for accessibility alignment chore(Cross): [IOAPPX-358] Updates io-app-design-system for accessibility alignment Jul 29, 2024
@CrisTofani CrisTofani requested a review from Hantex9 July 29, 2024 15:36
@CrisTofani CrisTofani changed the title chore(Cross): [IOAPPX-358] Updates io-app-design-system for accessibility alignment chore(Cross): [IOAPPX-358] Updates io-app-design-system for accessibility improvements Jul 29, 2024
@CrisTofani
Copy link
Contributor Author

@Hantex9 pls check if everything's fine on B&P side 😉

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.71%. Comparing base (4f204b4) to head (6ac8c52).
Report is 388 commits behind head on master.

Files Patch % Lines
ts/features/design-system/core/DSTextFields.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6064      +/-   ##
==========================================
+ Coverage   48.42%   48.71%   +0.28%     
==========================================
  Files        1488     1772     +284     
  Lines       31617    35855    +4238     
  Branches     7669     8644     +975     
==========================================
+ Hits        15311    17465    +2154     
- Misses      16238    18322    +2084     
  Partials       68       68              
Files Coverage Δ
ts/features/design-system/core/DSBadges.tsx 63.63% <ø> (+8.08%) ⬆️
ts/features/design-system/core/DSListItems.tsx 55.55% <ø> (+28.88%) ⬆️
.../features/fci/components/GenericErrorComponent.tsx 100.00% <ø> (ø)
ts/features/fci/components/SuccessComponent.tsx 77.14% <ø> (ø)
ts/features/fci/screens/FciRouterScreen.tsx 72.97% <ø> (ø)
...eatures/idpay/onboarding/screens/FailureScreen.tsx 2.56% <ø> (ø)
...ubscription/screens/UnsubscriptionResultScreen.tsx 22.22% <ø> (ø)
...es/messages/components/Home/DS/MessageListItem.tsx 100.00% <ø> (ø)
...essages/components/Home/legacy/MessagesArchive.tsx 8.00% <ø> (ø)
.../messages/components/Home/legacy/MessagesInbox.tsx 64.00% <ø> (ø)
... and 6 more

... and 1137 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ec38c5...6ac8c52. Read the comment docs.

@CrisTofani CrisTofani merged commit 8d7271d into master Aug 2, 2024
11 checks passed
@CrisTofani CrisTofani deleted the IOAPPX-358 branch August 2, 2024 13:16
dmnplb added a commit that referenced this pull request Oct 21, 2024
…h `IOText` + Add support for `Bold Text` a11y setting (#6076)

> [!warning]
> This PR depends on:
> * #6064

## Short description
This PR replaces the typographic styles generated through
`useTypographyFactory` with the new generic `IOText` typographic style.
It also adds the support for the **Bold text** a11y setting to all the
existing typographic styles.
 
## List of changes proposed in this pull request
- Update `io-app-design-system` to `2.0.0`
- Replace `LabelLink` with the relative `Label…` styles with the new
`asLink` prop
- Update `DSTypography` page to reflect all the latest changes
- Remove `MdH4`, `MdH5` and `MdH6` typographic styles because not
necessary
  
### Preview


https://github.com/user-attachments/assets/c65a4cdb-c6dc-490a-8e3b-0b6164386769



## How to test
To define

---------

Co-authored-by: Cristiano Tofani <cri.tofani@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Activities related to accessibility Cross dont-merge ✋ keep open
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants