Replace to ts-graphviz package #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, it seems that ts-graphviz fails on Node 10, 12, and 13 versions running on CI, since ts-graphviz supports Node 14 and above, in line with Node.js LTS. Whether or not to support older Node versions depends on the policy of the package, so if the policy is to support LTS only, I would be happy to merge this pull request. |
kamiazya
force-pushed
the
depend-to-ts-graphviz
branch
from
fdfb0f3
to
234e06a
Compare
|
I created pull request to modify to support LTS only. As I mentioned in this pull request, I would be happy for you to decide if you want to merge with this project policy. |
pahen
approved these changes
Jan 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm @kamiazya, the developer of the ts-graphviz package.
I was testing the possibility of replacing graphviz package's use cases with ts-graphviz using madge project.
I have successfully replaced the use cases of the graphviz package in madge with ts-graphviz and created a pull request.
Since the graphviz package is not actively maintained, I think I can contribute to closing issues that depend on the graphviz package, such as #327.
Thanks!