Add warning when size is too small #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willgearty
changed the title
willgearty
changed the title
|
This is now updated for the precompiled vignettes. |
LewisAJones
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Hi @willgearty, good job, this seems to work great. Some very minor comments/suggestions!
Co-authored-by: Lewis A. Jones <41071747+LewisAJones@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This throws a warning if the specified (or default) size is too small compared to the limits of the y axis (less than 1/1000th). This is mostly for when geom_phylopic is used with coord_sf and the data is projected/transformed.
I've also added an example to the vignette that showcases using coord_sf and a projection.
Fixes #86.