Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime error with Webpack v5 #4393

Closed
benochr opened this issue Oct 29, 2020 · 3 comments
Closed

Runtime error with Webpack v5 #4393

benochr opened this issue Oct 29, 2020 · 3 comments
Assignees

Comments

@benochr
Copy link

benochr commented Oct 29, 2020

Environment

  • Package version(s): 3.35.0
  • Operating System: MacOS Catalina 10.15.7
  • Browser name and version: Chrome 86.0.4240.111

Actual behavior

When building with Webpack v5.3.0 we get a runtime error.

classes.js:20 Uncaught ReferenceError: process is not defined
    at Module../node_modules/@blueprintjs/core/lib/esm/common/classes.js (classes.js:20)
    at __webpack_require__ (bootstrap:18)

Webpack 5 no longer includes polyfills for it, as described here

Expected behavior

No runtime errors. Support builds with webpack 5.

@adidahiya
Copy link
Contributor

I'll update the code to avoid referencing process directly. In the meantime you can work around this with DefinePlugin or EnvironmentPlugin.

@jasongrout
Copy link

This would also fix #3703

In the meantime you can work around this with DefinePlugin or EnvironmentPlugin.

See #3739 (comment) for an example.

@adidahiya adidahiya added the P1 label Dec 21, 2020
jasongrout added a commit to jasongrout/ipywidgets that referenced this issue Jun 11, 2021
jasongrout added a commit to jasongrout/ipywidgets that referenced this issue Jun 11, 2021
@adidahiya
Copy link
Contributor

fixed by #4934

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants