ESLint Errors/Warnings Not Showing In VS Code

[rushvora]

When using the plugin, no warnings show up in the editor at all. The linting does work as expected, but the errors or warnings that show up in the editor disappear completely. I've attached a video of the ESLint errors showing up in VS code when the plugin is not present.

vs-code-eslint-plugin-diff-bug.mp4

[paleite]

thanks for reporting this! looking into it

[paleite]

I think the issue here is that the files are untracked, which means they won’t be linted.
I’m working on changing this though, so the plug-in WILL lint untracked files, but in the meantime, you can stage the files you want to lint and it should work.
leaving this issue open, since i’m still working on the fix, but should be out this week

[rushvora]

The errors don't show up for the tracked files either. They do show up in the shell when trying to commit, and it works perfectly at that time. Just not in VS Code when editing the file.

[paleite]

I've released a new (alpha) version: https://www.npmjs.com/package/eslint-plugin-diff/v/1.0.13-0
Please try it out and see if that fixes your issues. Untracked files will now be picked up when using plugin:diff/diff.

If it's still not working for you in VSCode, could you please paste your ESLint output? You can copy/paste it from ESLint: Show Output Channel

Thanks in advance!

[rushvora]

1.0.13-0 didn't change anything for me.

The output from ESLint -

[Info  - 11:23:24] ESLint server is starting
[Info  - 11:23:25] ESLint server running in node v14.16.0
[Info  - 11:23:25] ESLint server is running.
[Info  - 11:23:26] ESLint library loaded from: /path-to-folder-here/node_modules/eslint/lib/api.js

Let me know if I can help in any way. I made changes that should throw up linting errors in both tracked and untracked files. The errors get flagged to prevent the commit, but they still don't show up in VS Code.

[paleite]

Hi! Please try https://www.npmjs.com/package/eslint-plugin-diff/v/1.0.13-3

I think the reason we got this bug was because the ESLint plugin for VSCode is a long-running process. I was able to replicate the issue locally and it should be fixed now. Please give it a try and let me know if it works.

Note: because the plugin is using git under the hood, it won’t be able to start showing the linter errors until after you’ve saved your file.

[rushvora]

On initial testing, it doesn't seem to be fixed. 😞
I'll test it out further sometime next week.

[rushvora]

Still no change in behaviour for me 😓
Linting warnings/errors still don't show up in VS Code for changed lines, after the file has been saved.

[marmaak]

Hi @paleite , I tested the latest version (1.0.13-4) but at least on my side the wrong behaviour is still there. I noticed that if I change a line (introducing an error) and then save the file, VSC plugin does not highlight the error. Then if I restart the ESLint server (from VSC) it starts to show the issue on the IDE.

Could it be a cache issue maybe?

[maxerbox]

Same with 1.0.13-4
eslintrc:

{
	"parser": "@typescript-eslint/parser",
	"extends": [
		"plugin:@typescript-eslint/recommended",
		"prettier/@typescript-eslint",
		"plugin:prettier/recommended",
		"plugin:react/recommended", // see https://github.com/jsx-eslint/eslint-plugin-react#configuration. React good practices
		"plugin:diff/diff" // see https://github.com/paleite/eslint-plugin-diff. Lint only changed files.
	],
	"settings": {
		"react": {
			"version": "16.9"
		}
	},
	"parserOptions": {
		"ecmaVersion": 2018,
		"sourceType": "module"
	},
	"rules": {
		// HACK: one day, enable those rules
		"@typescript-eslint/explicit-member-accessibility": 0,
		"@typescript-eslint/no-explicit-any": 0,
		"@typescript-eslint/explicit-function-return-type": 0,
		"@typescript-eslint/no-unused-vars": 0
	}
}

[maxerbox]

Work now in 1.0.15