Skip to content

Fix renamed and modified files not handled. #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2022
Merged

Conversation

mathieutu
Copy link
Contributor

@mathieutu mathieutu commented Apr 15, 2022

Hi,

Thanks for this project!

I've just seen that if you modify and rename a file, git will by default consider it as renamed if less than 50% of it changed.

Here, we want to lint every file whose content has changed, so we have to add the -M100% attribute.

You can see the doc about that here.

Thanks!

@mathieutu
Copy link
Contributor Author

@paleite pinging just in case you don't watch the repo (it happened to me a lot! 😅)

@paleite
Copy link
Owner

paleite commented Jun 5, 2022

@mathieutu Wow, this is awesome! Thanks a lot!

I was wondering how one could solve that issue, and I'm really grateful that you've contributed 🙂 Thanks!

@paleite paleite merged commit cc61385 into paleite:main Jun 5, 2022
@paleite
Copy link
Owner

paleite commented Jun 5, 2022

Published: https://www.npmjs.com/package/eslint-plugin-diff/v/1.0.13-5

currently still in next, but will be released as stable soon

Again, thanks for your contribution 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants