Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bash completion on chained command arguments #771

Closed

Conversation

stopthatcow
Copy link
Contributor

@stopthatcow stopthatcow commented Apr 29, 2017

Enables bash completion on chained command arguments, allows completions with spaces in them, makes bash completion about 10ms faster by exiting python using os._exit() rather than sys.exit(), and updates documentation that was incorrect from PR #755

Fixes #754
Fixes #769

@stopthatcow
Copy link
Contributor Author

@Gig77 Feel free to see if this solves your issue.

@Gig77
Copy link

Gig77 commented Apr 29, 2017

It does, thanks a lot!

@stopthatcow stopthatcow changed the title Feature/chained completion Fix bash completion on chained command arguments May 1, 2017
@stopthatcow
Copy link
Contributor Author

@untitaker I'd love to get your thoughts on this.

@untitaker
Copy link
Contributor

untitaker commented May 2, 2017

A lot of unrelated things are in this PR, I'm unsure if we want fast_exit. It potentially makes this a pain to test.

@stopthatcow
Copy link
Contributor Author

stopthatcow commented May 2, 2017

@untitaker good call. I broke this into #772, #773, #774, and #775. I think fast_exit in this specific case is ok because it is only used when bash completion is invoked (something we don't test directly). If we did want to test it we'd just need to launch the test using subprocess. Bzr actually uses this 'trick' in all exit code paths I believe to try to be more responsive as a CLI. I got the inspiration from here.

@stopthatcow stopthatcow closed this May 2, 2017
@stopthatcow stopthatcow deleted the feature/chained_completion branch May 2, 2017 15:30
@untitaker
Copy link
Contributor

we'd just need to launch the test using subprocess.

not a huge fan of this, but we'll see when we get to test it. I was thinking more about monkeypatching fast_exit.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants