Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): WalletConnect v2 #5963

Closed
wants to merge 4 commits into from
Closed

Conversation

chef-jojo
Copy link
Collaborator

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2023

⚠️ No Changeset found

Latest commit: 4c5fc28

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aptos-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 0:41am
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 0:41am
bridge ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 0:41am
uikit ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 0:41am
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 0:41am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
og-image ⬜️ Ignored (Inspect) Visit Preview May 8, 2023 0:41am

@antondalgren
Copy link

Would you consider removing the requirements for these methods (eth_sign, eth_signTransaction, eth_sendRawTransaction) due to security reasons for wallets and in the end users?

References:

@chef-jojo
Copy link
Collaborator Author

Would you consider removing the requirements for these methods (eth_sign, eth_signTransaction, eth_sendRawTransaction) due to security reasons for wallets and in the end users?

References:

Thanks for bring this up. will take a look with WC team, this should be able to config on connector options

@socket-security
Copy link

socket-security bot commented May 8, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Critical CVE ✅ 0 issues
CVE ✅ 0 issues
Mild CVE ✅ 0 issues
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Filesystem access ✅ 0 issues
Environment variable access ✅ 0 issues
Missing dependency ✅ 0 issues
Unused dependency ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Bad semver ✅ 0 issues
Bad dependency semver ✅ 0 issues
CommonJS depending on ESModule ✅ 0 issues
Deprecated ✅ 0 issues
Major refactor ✅ 0 issues
Unsafe copyright ✅ 0 issues
Modified license ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
AI detected security risk ✅ 0 issues
AI warning ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
wagmi@0.12.13 0.12.12...0.12.13 None +33/-96 awkweb
@wagmi/core@0.10.11 0.10.10...0.10.11 None +20/-62 awkweb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants