GH1398 Remove cast from Index(..., dtype='categorical').array #1414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmp0xff
requested changes
Oct 9, 2025
cmp0xff
requested changes
Oct 9, 2025
Comment on lines
23
to
30
| @type_check_only | ||
| class CategoricalArrayDescriptor: | ||
| def __get__(self, instance, owner: type[IndexOpsMixin]) -> Categorical: ... | ||
|
|
||
| class CategoricalIndex(ExtensionIndex[S1], accessor.PandasDelegate): | ||
| codes: np.ndarray = ... | ||
| categories: Index = ... | ||
| array = CategoricalArrayDescriptor() # pyrefly: ignore[bad-override] |
There was a problem hiding this comment.
There is only one return type, so we can use a static @property instead.
Suggested change
| @type_check_only | |
| class CategoricalArrayDescriptor: | |
| def __get__(self, instance, owner: type[IndexOpsMixin]) -> Categorical: ... | |
| class CategoricalIndex(ExtensionIndex[S1], accessor.PandasDelegate): | |
| codes: np.ndarray = ... | |
| categories: Index = ... | |
| array = CategoricalArrayDescriptor() # pyrefly: ignore[bad-override] | |
| class CategoricalIndex(ExtensionIndex[S1], accessor.PandasDelegate): | |
| codes: np.ndarray = ... | |
| categories: Index = ... | |
| @property | |
| def array(self) -> Categorical: ... # pyrefly: ignore[bad-override] |
cmp0xff
approved these changes
Oct 10, 2025
There was a problem hiding this comment.
It looks good to me. I assume that you have finished the PR but forgot to click request review. Thank you @loicdiridollou !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Index([1], dtype="category").arraygivesExtensionArrayinstead ofpd.Categorical#1398assert_type()to assert the type of any return value