Skip to content

GH1419 Allow Series and Index for other in Index.where(..., other) #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

GH1419 Allow Series and Index for other in Index.where(..., other) #1420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86c94eb
GH1419 Allow Series and Index for other in Index.where(..., other)
loicdiridollou Oct 9, 2025
a6653dc
GH1419 PR Feedback
loicdiridollou Oct 10, 2025
0659166
GH1419 PR Feedback
loicdiridollou Oct 10, 2025
96c8a14
GH1419 PR Feedback
loicdiridollou Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pandas-stubs/core/indexes/base.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ from pandas._typing import (
T_COMPLEX,
T_INT,
AnyAll,
ArrayLike,
AnyArrayLike,
AxesData,
CategoryDtypeArg,
DropKeep,
Expand Down Expand Up @@ -434,7 +434,7 @@ class Index(IndexOpsMixin[S1]):
@property
def values(self) -> np_1darray: ...
def memory_usage(self, deep: bool = False): ...
def where(self, cond, other: Scalar | ArrayLike | None = None): ...
def where(self, cond, other: Scalar | AnyArrayLike | None = None) -> Self: ...
def __contains__(self, key) -> bool: ...
@final
def __setitem__(self, key, value) -> None: ...
Expand Down
25 changes: 25 additions & 0 deletions tests/indexes/test_indexes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
from pandas.core.arrays.timedeltas import TimedeltaArray
from pandas.core.indexes.base import Index
from pandas.core.indexes.category import CategoricalIndex
from pandas.core.indexes.datetimes import DatetimeIndex
from typing_extensions import (
Never,
assert_type,
Expand Down Expand Up @@ -1608,3 +1609,27 @@ def test_to_series() -> None:
np.complexfloating,
)
check(assert_type(Index(["1"]).to_series(), "pd.Series[str]"), pd.Series, str)


def test_index_where() -> None:
"""Test Index.where with multiple types of other GH1419."""
idx = pd.Index(range(48))
mask = np.ones(48, dtype=bool)
val_idx = idx.where(mask, idx)
check(assert_type(val_idx, "pd.Index[int]"), pd.Index, int)

val_sr = idx.where(mask, (idx).to_series())
check(assert_type(val_sr, "pd.Index[int]"), pd.Index, int)


def test_datetimeindex_where() -> None:
"""Test DatetimeIndex.where with multiple types of other GH1419."""
datetime_index = pd.date_range(start="2025-01-01", freq="h", periods=48)
mask = np.ones(48, dtype=bool)
val_idx = datetime_index.where(mask, datetime_index - pd.Timedelta(days=1))
check(assert_type(val_idx, DatetimeIndex), DatetimeIndex)

val_sr = datetime_index.where(
mask, (datetime_index - pd.Timedelta(days=1)).to_series()
)
check(assert_type(val_sr, DatetimeIndex), DatetimeIndex)