BUG: Fix MultiIndex.dtypes (#597) #603
Conversation
pandas-stubs/core/indexes/multi.pyi
Outdated
| @property | ||
| def dtype(self) -> np.dtype: ... | ||
| @property | ||
| def dtypes(self) -> pd.Series[Any]: ... |
There was a problem hiding this comment.
Could probably be tightened to pd.Series[numpy.dtype | pd.api.extensions.ExtensionDtype] but that probably causes trouble (I don't think those classes are part of S1)
There was a problem hiding this comment.
With pd.Series[numpy.dtype | pd.api.extensions.ExtensionDtype] mypy says
pandas-stubs/core/indexes/multi.pyi:73: error: Invalid type argument value for "Series" [type-var]
tests/test_indexes.py:862: error: Invalid type argument value for "Series" [type-var]
There was a problem hiding this comment.
Actually, the dtype of the returned Series is object, since it is a Series of dtypes. You could try adding Dtype to S1 in _typing.pyi but that might break other things. If it doesn't break anything, then you could return Series[Dtype]
pandas-stubs/core/indexes/multi.pyi
Outdated
| @property | ||
| def dtype(self) -> np.dtype: ... | ||
| @property | ||
| def dtypes(self) -> pd.Series[Any]: ... |
There was a problem hiding this comment.
Actually, the dtype of the returned Series is object, since it is a Series of dtypes. You could try adding Dtype to S1 in _typing.pyi but that might break other things. If it doesn't break anything, then you could return Series[Dtype]
It seems to work in the sense that |
* Fix MultiIndex.dtypes (pandas-dev#597) * Tighten the MultiIndex.dtypes return value to Dtype
3 participants
assert_type()to assert the type of any return value