Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: full dtype tests for .drop_duplicates and .duplicated #15752

Open
jreback opened this Issue Mar 20, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@jreback
Copy link
Contributor

commented Mar 20, 2017

#15738 (comment)
xref #15738

we exercise tests for .drop_duplicates & .duplicated in various places

  • for series -> pandas/tests/series/test_analytics.py
  • for dataframe -> pandas/test/frame/test_analytics.py
  • for index -> pandas/tests/test_base.py
  • datetimes -> pandas/tests//indexes/datetimes/test_ops.py
  • period -> pandas/tests//indexes/period/test_ops.py
  • categorical -> pandas/tests//test_categorical.py
  • timedelta -> pandas/tests//indexes/timedeltas/test_ops.py

I think we are a little light on the categorical ones (esp need to exercise with categories of int, datetime, timedelta, bool)

bool and a battery that covers all int & uint & float would be nice as well.

could certainly take multiple PR's to close this issue (if multiple people want to do this).

@jreback jreback modified the milestones: 0.20.0, Next Major Release Mar 20, 2017

tmnhat2001 added a commit to tmnhat2001/pandas that referenced this issue Oct 25, 2017

tmnhat2001 added a commit to tmnhat2001/pandas that referenced this issue Oct 25, 2017

@tmnhat2001

This comment has been minimized.

Copy link
Contributor

commented Oct 25, 2017

Hi, could someone take a look at the test cases added in PR 17974? The test cases are for Series. If they are OK, I'll do the same to the remaining tests.
#17974

tmnhat2001 added a commit to tmnhat2001/pandas that referenced this issue Oct 26, 2017

tmnhat2001 added a commit to tmnhat2001/pandas that referenced this issue Oct 27, 2017

tmnhat2001 added a commit to tmnhat2001/pandas that referenced this issue Oct 28, 2017

jreback added a commit that referenced this issue Oct 31, 2017

GuessWhoSamFoo added a commit to GuessWhoSamFoo/pandas that referenced this issue Nov 1, 2017

jreback added a commit that referenced this issue Nov 6, 2017

No-Stream added a commit to No-Stream/pandas that referenced this issue Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.