Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFrame.unstack(label) accepts wrong labels if index is flat #18303

Closed
toobaz opened this issue Nov 15, 2017 · 3 comments · Fixed by #27631

Comments

@toobaz
Copy link
Member

commented Nov 15, 2017

Code Sample, a copy-pastable example if possible

In [2]: df = pd.DataFrame(index=range(2), columns=pd.MultiIndex.from_product([range(2), range(2)]))

In [3]: df.unstack('mistake')
Out[3]: 
0  0  0    NaN
      1    NaN
   1  0    NaN
      1    NaN
1  0  0    NaN
      1    NaN
   1  0    NaN
      1    NaN
dtype: object

Problem description

An error should be raised.

Expected Output

KeyError

Output of pd.show_versions()

In [4]: pd.show_versions()

INSTALLED VERSIONS

commit: 63e8527
python: 3.5.3.final.0
python-bits: 64
OS: Linux
OS-release: 4.9.0-3-amd64
machine: x86_64
processor:
byteorder: little
LC_ALL: None
LANG: it_IT.UTF-8
LOCALE: it_IT.UTF-8

pandas: 0.22.0.dev0+131.g63e8527d3
pytest: 3.2.3
pip: 9.0.1
setuptools: 36.7.0
Cython: 0.25.2
numpy: 1.12.1
scipy: 0.19.0
pyarrow: None
xarray: None
IPython: 6.2.1
sphinx: 1.5.6
patsy: 0.4.1
dateutil: 2.6.1
pytz: 2017.2
blosc: None
bottleneck: 1.2.0dev
tables: 3.3.0
numexpr: 2.6.1
feather: 0.3.1
matplotlib: 2.0.0
openpyxl: None
xlrd: 1.0.0
xlwt: 1.1.2
xlsxwriter: 0.9.6
lxml: None
bs4: 4.5.3
html5lib: 0.999999999
sqlalchemy: 1.0.15
pymysql: None
psycopg2: None
jinja2: 2.10
s3fs: None
fastparquet: None
pandas_gbq: None
pandas_datareader: 0.2.1

@gfyoung gfyoung added the Reshaping label Nov 16, 2017

@gfyoung

This comment has been minimized.

Copy link
Member

commented Nov 16, 2017

@toobaz : Do you know if there was a release where an error should have been raised, or are you suggesting that we change the API to raise KeyError in a situation like this?

@toobaz

This comment has been minimized.

Copy link
Member Author

commented Nov 16, 2017

Yes, I'm suggesting it should raise a KeyError, like pd.Index([]).get_level_values('mistake') does.

By the way, I've always found the error message KeyError: 'Level mistake must be same as name (None)' raised by the latter confusing... I would suggest harmonizing with the error raised by MultiIndex.get_level_values("mistake") (that is, KeyError: 'Level "mistake" not found'), and/or to add info on the available names (KeyError: 'Level "mistake" not found in index level names ([None])').

@gfyoung

This comment has been minimized.

Copy link
Member

commented Nov 16, 2017

@toobaz : Ah, okay, so not quite answering my question, BUT that's fine since your answer is pretty good justification for the issue anyhow.

As for your other point, yes, that's also fair. If you want, you can open another issue for that OR just open a PR to patch the behavior if it's clear how to fix.

toobaz added a commit to toobaz/pandas that referenced this issue Jul 28, 2019
toobaz added a commit to toobaz/pandas that referenced this issue Jul 28, 2019
toobaz added a commit to toobaz/pandas that referenced this issue Jul 28, 2019
toobaz added a commit to toobaz/pandas that referenced this issue Jul 29, 2019
toobaz added a commit to toobaz/pandas that referenced this issue Jul 29, 2019
toobaz added a commit to toobaz/pandas that referenced this issue Jul 29, 2019

@jreback jreback added this to the 0.25.1 milestone Jul 29, 2019

jreback added a commit that referenced this issue Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.