New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change UInt64Index._na_value from 0 to np.nan #18398

Closed
jschendel opened this Issue Nov 21, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@jschendel
Member

jschendel commented Nov 21, 2017

Code Sample, a copy-pastable example if possible

In [2]: pd.UInt64Index._na_value
Out[2]: 0

Problem description

The basic logic here is that UInt64Index should mimic Int64Index in that it cannot hold na. As it's currently defined, UInt64Index can hold it's _na_value, which brings about issues for internal code that uses _na_value.

Relevant discussion here.

Simply making the change from 0 to np.nan breaks a couple tests, and brings to light an existing bug, so there's a little more work than just changing _na_value. Will submit a PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment