New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leveraging find_packages in setup.py #18535

Closed
WillAyd opened this Issue Nov 28, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@WillAyd
Member

WillAyd commented Nov 28, 2017

Right now when creating new folders we have to also list them as packages in the setup.py file. Is there any reason why we have not considered using find_packages as suggested by the Python Packaging User Guide to take care of that?

Happy to submit a PR just not an expert on packaging, so wanted to discuss what if any caveats are out there first before making any changes

@jreback

This comment has been minimized.

Contributor

jreback commented Nov 28, 2017

no we should switch to find_packages

it didn’t exist in older setup tools (in theory we should have a min in setup tools but it can be pretty loose)

@jreback jreback added the Build label Nov 28, 2017

@jreback jreback added this to the 0.22.0 milestone Nov 28, 2017

@WillAyd WillAyd referenced this issue Dec 4, 2017

Merged

CLN: Replaced package list with find_packages #18632

3 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment