Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min_i argument to nancorr #2002

jreback opened this issue Oct 1, 2012 · 1 comment


Copy link

commented Oct 1, 2012

add an argument, min_i (minimum intersection) to nancorr in pandas.src.moments.pyx

this will nan the element if the nobs is < min_i (which should default to 1 to replicate current operations)

need to also propogate argument to: core.frame.corr/cov
possibly add to: core.series.corr/cov

def nancorr(ndarray[float64_t, ndim=2] mat, cov=False, min_i=1):
        Py_ssize_t i, j, xi, yi, N, K
        ndarray[float64_t, ndim=2] result
        ndarray[uint8_t, ndim=2] mask
        int64_t nobs = 0
        float64_t vx, vy, sumx, sumy, sumxx, sumyy, meanx, meany, divisor

    N, K = (<object> mat).shape

    result = np.empty((K, K), dtype=np.float64)
    mask = np.isfinite(mat).view(np.uint8)

    for xi in range(K):
        for yi in range(xi + 1):
            nobs = sumxx = sumyy = sumx = sumy = 0
            for i in range(N):
                if mask[i, xi] and mask[i, yi]:
                    vx = mat[i, xi]
                    vy = mat[i, yi]
                    nobs += 1
                    sumx += vx
                    sumy += vy

            #### change from nobs == 0 ####
            if nobs < min_i:
                result[xi, yi] = result[yi, xi] = np.NaN
                meanx = sumx / nobs
                meany = sumy / nobs

                # now the cov numerator
                sumx = 0

                for i in range(N):
                    if mask[i, xi] and mask[i, yi]:
                        vx = mat[i, xi] - meanx
                        vy = mat[i, yi] - meany

                        sumx += vx * vy
                        sumxx += vx * vx
                        sumyy += vy * vy

                divisor = (nobs - 1.0) if cov else sqrt(sumxx * sumyy)

                if divisor != 0:
                    result[xi, yi] = result[yi, xi] = sumx / divisor
                    result[xi, yi] = result[yi, xi] = np.NaN

    return result
changhiskhan pushed a commit that referenced this issue Nov 24, 2012

This comment has been minimized.

Copy link

commented Nov 24, 2012

closed via 8d277e3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.