-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor DataFrame.combine for datetimelike #23079
Labels
Projects
Milestone
Comments
This was referenced Oct 10, 2018
TomAugspurger
added a commit
to TomAugspurger/pandas
that referenced
this issue
Oct 24, 2018
TomAugspurger
added a commit
to TomAugspurger/pandas
that referenced
this issue
Oct 24, 2018
TomAugspurger
added a commit
to TomAugspurger/pandas
that referenced
this issue
Oct 24, 2018
jreback
pushed a commit
that referenced
this issue
Oct 26, 2018
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this issue
Nov 19, 2018
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this issue
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this issue
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
In DataFrame.combine, we handle datetimelike data special.
pandas/pandas/core/frame.py
Line 5116 in 296c251
We attempt to pass a third argument to the combining
func
. This breaks things likeWe could document that, but it still feels hacky. I'd rather that the
combiner
func infer whether an i8 conversion is needed.xref #3595
The text was updated successfully, but these errors were encountered: