Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
test_pct_max_many_rows fails on intel 32bit with memory error #25384
Pytest output from the two failing tests:
Full build log:
How much memory does the machine you're running the tests on have? My initial suspicion is that the machine simply doesn't have enough memory to run those specific tests. We actually had a similar issue where these tests would intermittently crash fail on travis. The cause was eventually determined to be a memory error when running the tests in distributed mode, due to another test that happened to be running concurrently pushing beyond the memory limit (hence these currently being marked as single).
The bug that's being tested here was a bit strange in that it only occurred when more than 224 rows were present, so the minimal unit test needed to have 224+1 rows, which is why these tests need as much memory as they do.
A couple options come to mind here:
Not really sure which would be preferable, or if my low memory machine theory is even correct.
All that being said, it's certainly possible that there is a resource leak somewhere, or that memory isn't being used optimally, so investigations along those paths would certainly be welcome.
Thanks for checking. I think either a marker for high-memory, or a catch for a MemoryError is fine to fix this. Are you interested in submitting a PR?…
On Thu, Feb 21, 2019 at 6:02 AM Tomáš Chvátal ***@***.***> wrote: Okay can confirm the MemoryError happens also with 4GB ram allocated on the buildbot. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#25384 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIlJNkFtCxoNxGZVhBqC7d4jkb5toks5vPorZgaJpZM4bE4Rq> .