Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: test_yahoo/test_options is failing (return no data) #4028

Closed
jreback opened this issue Jun 25, 2013 · 15 comments · Fixed by #4002, #4048 or #4054
Closed

TST: test_yahoo/test_options is failing (return no data) #4028

jreback opened this issue Jun 25, 2013 · 15 comments · Fixed by #4002, #4048 or #4054
Labels
IO Data IO issues that don't fit into a more specific label Testing pandas testing functions or related to the test suite
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Jun 25, 2013

#3822 test_options is failing

cc @gliptak

@jreback
Copy link
Contributor Author

jreback commented Jun 27, 2013

still failing sometimes

cc @gliptak

@gliptak
Copy link
Contributor

gliptak commented Jun 27, 2013

@jreback I looked at @cpcloud 's changes, I understand the benefits of smaller tests, but not sure to follow how these are actually failing ...

@jreback
Copy link
Contributor Author

jreback commented Jun 27, 2013

the test_yahoo/test_options is failing sometimes
in that it returns no data

I have seen it fail on Travis and when I run it locally
it's not very time

see if u can figure out what it is

thanks

@gliptak
Copy link
Contributor

gliptak commented Jun 27, 2013

ok, I read through #3982 those should be covered by @network let's see what shows up after all of @cpcloud 's fixes are committed

@jtratner
Copy link
Contributor

I think @cpcloud's handled the AttributeError and others...are you seeing
something different?

On Thu, Jun 27, 2013 at 7:56 PM, gliptak notifications@github.com wrote:

ok, I read through #3982 https://github.com/pydata/pandas/issues/3982those should be covered by
@network let's see what shows up after all of @cpcloudhttps://github.com/cpcloud's fixes are committed


Reply to this email directly or view it on GitHubhttps://github.com//issues/4028#issuecomment-20162987
.

@jreback
Copy link
Contributor Author

jreback commented Jun 28, 2013

the option call sometimes returns nothing (not an error just no calls or puts)
it is probably an error somewhere that is being swallowed

@gliptak
Copy link
Contributor

gliptak commented Jun 28, 2013

if specifically the options calls failing, I would suspect the parsing of the HTML

@cpcloud
Copy link
Member

cpcloud commented Jun 28, 2013

man this is annoying

@cpcloud cpcloud reopened this Jun 28, 2013
@cpcloud
Copy link
Member

cpcloud commented Jun 28, 2013

@cpcloud
Copy link
Member

cpcloud commented Jun 28, 2013

i think we should wait for cleanup of data.py...i can finish up this weekend and get to the bottom of this maybe even today

@jreback
Copy link
Contributor Author

jreback commented Jun 28, 2013

up 2 you...it seems to work sometimes....

i'll bet that the actual call just returns invalid xml sometimes which really should be treated as an error

@cpcloud
Copy link
Member

cpcloud commented Jun 28, 2013

yep, but it's annoying because it's in the method and would be hard to test for the error, because e.g., you could parse in the test and check for the non-null root node, but i bet it willl parse successfully outside the call and then still fail inside

@cpcloud
Copy link
Member

cpcloud commented Jun 28, 2013

waiting for data.py cleanup will enable me to only write the error check once since i've consolidated all of the exact copied code in Options

@jreback
Copy link
Contributor Author

jreback commented Jun 28, 2013

ok....I thought you were merging the data cleanup now?

@cpcloud
Copy link
Member

cpcloud commented Jun 28, 2013

no i need to do 1 or 2 more things...soon tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Data IO issues that don't fit into a more specific label Testing pandas testing functions or related to the test suite
Projects
None yet
4 participants