TST/BUG: fix failing data.py tests for good #4054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
👍 |
|
thanks. i'm going to do a couple more rehashes + push to make sure nothing is falling through the cracks. 4-5 seems to be the magic number to get at least one fail in the build matrix. i think i've done 2 so far |
|
Could you cc me when you merge this one? |
|
@woodb sure thing |
|
@jreback look ok? the last 4 git rehashes and force pushes have passed on travis. running another one just in case. when that succeeds i wiil merge |
|
ok by me |
|
bombs away................ |
cpcloud
added a commit
that referenced
this pull request
Jun 28, 2013
TST/BUG: fix failing data.py tests for good
|
cc @woodb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4028, #3982. for good.