Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LastWeekOfMonth DateOffset #4637

Closed
cancan101 opened this issue Aug 22, 2013 · 5 comments

Comments

Projects
None yet
4 participants
@cancan101
Copy link
Contributor

commented Aug 22, 2013

Create a DateOffset that represents the a weekday in last week of the month, such as "the last Tuesday of each month"

Currently there is a WeekOfMonth DateOffset but that class only takes week : {0, 1, 2, 3, ...}. What we actually want is week=-1

I will submit a PR.

@jreback

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2013

I added a 'Frequency' label to tag some of these issues

@cancan101

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2013

@jreback I have a PR in progress for this. It's part of #4511

@patricktokeeffe

This comment has been minimized.

Copy link
Contributor

commented Oct 30, 2013

I'm curious why this was implemented as a new class instead of extending the range for WeekOfMonth into the negative range. It seems valid enough to say "the second to last Tuesday of each month" or week=-2.

@cancan101

This comment has been minimized.

Copy link
Contributor Author

commented Oct 30, 2013

I don't think there is a good reason. I would not be averse to just merging that functionality into WeekOfMonth

@jreback

This comment has been minimized.

Copy link
Contributor

commented Feb 18, 2014

closed by #5004

@jreback jreback closed this Feb 18, 2014

@jorisvandenbossche jorisvandenbossche modified the milestones: 0.13, 0.16.0 Apr 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.