Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: drop_duplicates raises unexpected error for bool[pyarrow] with null value #54667

Closed
2 of 3 tasks
rohanjain101 opened this issue Aug 21, 2023 · 0 comments · Fixed by #54670
Closed
2 of 3 tasks

BUG: drop_duplicates raises unexpected error for bool[pyarrow] with null value #54667

rohanjain101 opened this issue Aug 21, 2023 · 0 comments · Fixed by #54670
Labels
Arrow pyarrow functionality Bug duplicated duplicated, drop_duplicates

Comments

@rohanjain101
Copy link
Contributor

Pandas version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • I have confirmed this bug exists on the main branch of pandas.

Reproducible Example

>>> dd = pd.DataFrame({"A": pd.Series([True, False, None], dtype="bool[pyarrow]")})
>>> dd.drop_duplicates()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "E:\pd_dev_0814\Lib\site-packages\pandas\core\frame.py", line 6568, in drop_duplicates
    result = self[-self.duplicated(subset, keep=keep)]
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "E:\pd_dev_0814\Lib\site-packages\pandas\core\frame.py", line 6704, in duplicated
    result = self[subset[0]].duplicated(keep)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "E:\pd_dev_0814\Lib\site-packages\pandas\core\series.py", line 2484, in duplicated
    res = self._duplicated(keep=keep)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "E:\pd_dev_0814\Lib\site-packages\pandas\core\base.py", line 1368, in _duplicated
    return algorithms.duplicated(self._values, keep=keep)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "E:\pd_dev_0814\Lib\site-packages\pandas\core\algorithms.py", line 1003, in duplicated
    values = _ensure_data(values)
             ^^^^^^^^^^^^^^^^^^^^
  File "E:\pd_dev_0814\Lib\site-packages\pandas\core\algorithms.py", line 155, in _ensure_data
    return np.asarray(values).astype("uint8", copy=False)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: int() argument must be a string, a bytes-like object or a real number, not 'NAType'
>>>

Issue Description

The error is not expected, the call to drop_duplicates should succeed.

Expected Behavior

I expect this example to succeed. If the null value is removed, the call succeeds.

>>> dd = pd.DataFrame({"A": pd.Series([True, False], dtype="bool[pyarrow]")})
>>> dd.drop_duplicates()
       A
0   True
1  False
>>>

Installed Versions

INSTALLED VERSIONS

commit : 6e194cf
python : 3.11.2.final.0
python-bits : 64
OS : Windows
OS-release : 10
Version : 10.0.22621
machine : AMD64
processor : Intel64 Family 6 Model 85 Stepping 7, GenuineIntel
byteorder : little
LC_ALL : None
LANG : None
LOCALE : English_United States.1252

pandas : 2.1.0rc0
numpy : 1.25.2
pytz : 2023.3
dateutil : 2.8.2
setuptools : 68.0.0
pip : 23.2.1
Cython : None
pytest : 7.0.1
hypothesis : None
sphinx : 4.2.0
blosc : None
feather : None
xlsxwriter : None
lxml.etree : None
html5lib : None
pymysql : None
psycopg2 : None
jinja2 : 3.1.2
IPython : 8.14.0
pandas_datareader : None
bs4 : 4.12.2
bottleneck : None
brotli : None
dataframe-api-compat: None
fastparquet : None
fsspec : None
gcsfs : None
matplotlib : None
numba : None
numexpr : None
odfpy : None
openpyxl : None
pandas_gbq : None
pyarrow : 12.0.0
pyreadstat : None
pyxlsb : None
s3fs : None
scipy : None
snappy : None
sqlalchemy : None
tables : None
tabulate : 0.8.9
xarray : None
xlrd : None
zstandard : None
tzdata : 2023.3
qtpy : None
pyqt5 : None

@rohanjain101 rohanjain101 added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Aug 21, 2023
@phofl phofl added duplicated duplicated, drop_duplicates Arrow pyarrow functionality and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality Bug duplicated duplicated, drop_duplicates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants