Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in common na_values definition #5521

Closed
glaucouri opened this issue Nov 15, 2013 · 11 comments · Fixed by #5601 or #7639

Comments

@glaucouri
Copy link

commented Nov 15, 2013

Note for 0.14.1: need to add back #N/A N/A to na_values defaults

in pandas 0.12

i found a little bug:

this:
_NA_VALUES = set(['-1.#IND', '1.#QNAN', '1.#IND', '-1.#QNAN',
'#N/A N/A', 'NA', '#NA', 'NULL', 'NaN',
'nan', ''])

must be:
_NA_VALUES = set(['-1.#IND', '1.#QNAN', '1.#IND', '-1.#QNAN',
'#N/A','N/A', 'NA', '#NA', 'NULL', 'NaN',
'nan', ''])

thank you
Glauco

@jreback

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2013

this is not a bug. you can always specify your own na_values if you would like. Or are you advocating N/A be added to the 'common list'?

@jtratner

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2013

No, he's saying that currently one of the values is: '#N/A N/A'
but that should actually be two values '#N/A' and 'N/A' right? in other
words, there's a missing closing single-quote and comma.

@glaucouri

This comment has been minimized.

Copy link
Author

commented Nov 27, 2013

Exactly . Take a look at the snippet.

Inviato da Aifon

Il giorno 27/nov/2013, alle ore 19:41, Jeff Tratner notifications@github.com ha scritto:

No, he's saying that currently one of the values is: '#N/A N/A'
but that should actually be two values '#N/A' and 'N/A' right? in other
words, there's a missing closing single-quote and comma.

Reply to this email directly or view it on GitHub.

Il contenuto di questa e-mail è rivolto unicamente alle persone alle quali è indirizzato e può contenere informazioni la cui riservatezza è tutelata legalmente. Sono vietati la riproduzione, la diffusione e l’uso di questa e-mail in mancanza di autorizzazione del destinatario. Se avete ricevuto questa e-mail per errore vogliate cortesemente contattarci immediatamente.

This e-mail is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. Unauthorised reproduction, dissemination or use of this e-mail or of the information herein by anyone other than the intended recipient is prohibited. If you have received this e-mail by mistake, please notify us immediately.

@jtratner

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2013

yeah, it's just easy to miss the point because it's a typo and subtle to
boot :)

@jreback

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2013

#5601 should do it...

@jtratner

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2013

Thanks for catching this!

@djchou

This comment has been minimized.

Copy link

commented Jun 26, 2014

Actually, it wasn't a typo. Excel returns a '#N/A N/A' value sometimes. Please add this value back to the NA list.

@jreback

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2014

hmm, you are right, that should be their as well. wnat to do a PR for that?

@jreback jreback reopened this Jun 26, 2014

@jreback jreback modified the milestones: 0.14.1, 0.13 Jun 26, 2014

@glaucouri

This comment has been minimized.

Copy link
Author

commented Jun 26, 2014

Il 26/06/2014 15:37, djchou ha scritto:

Actually, it wasn't a typo. Excel returns a '#N/A N/A' value
sometimes. Please add this value back to the NA list.

did you have a test case?

Gla

@djchou

This comment has been minimized.

Copy link

commented Jun 26, 2014

Sorry, this is my first time using Github. I'm not sure what you mean by PR.

@jreback

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2014

pull-request, see here: https://github.com/pydata/pandas/wiki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.