Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push some of Series.ix into Series.__getitem__/__setitem__ #86

Closed
wesm opened this issue Jul 30, 2011 · 5 comments

Comments

@wesm
Copy link
Member

commented Jul 30, 2011

Should be able to do stuff like:

ts[date1:date2]

to mirror ts.ix[date1:date2]. Should respect integer labels while Series.ix will not

@changhiskhan

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2011

Why not push all of it into getitem/setitem?

def getitem(self, key):
self.ix[key]

def setitem(self, key, value):
self.ix[key] = value

@wesm

This comment has been minimized.

Copy link
Member Author

commented Nov 13, 2011

Oof. Please steer clear of this issue, it's full of performance landmines. I need to set up some benchmarks so I can evaluate all of the use cases

@wesm

This comment has been minimized.

Copy link
Member Author

commented Nov 13, 2011

In principle having all of it in getitem/setitem would be nice. but the use cases are complex

@changhiskhan

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2011

sounds like a reasonable approach. i'll let you take this one then :)

wesm added a commit that referenced this issue Jan 13, 2012
ENH: API change / refactoring in Series.__getitem__ and __setitem__ t…
…o implement #86, related tightening of integer index handling from #592
@wesm

This comment has been minimized.

Copy link
Member Author

commented Jan 13, 2012

Alright, this is done. Need to document the related API changes and add lots of WARNING, WARNING

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.