ENH: Add days_in_month property to Timestamp/DatetimeIndex/... (GH9572) #9605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josham looks gr8. after I wrote up the issue I realized that this should prob be named we could change these to a proper naming convention, but that's a different issue. |
|
see #9606 |
|
OK, I'll add daysinmonth |
days_in_month (compatibility alias ``daysinmonth``) added to Timestamp, DatetimeIndex, Period, PeriodIndex, Series.dt
jreback
added a commit
that referenced
this pull request
Mar 6, 2015
ENH: Add days_in_month property to Timestamp/DatetimeIndex/... (GH9572)
|
thanks @josham keep em coming! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9572
Added days_in_month property (compatibility alias daysinmonth) to Timestamp, DatetimeIndex, Period, PeriodIndex,
Series.dt.
Although not mentioned in the GH issue, I added the property to Period and PeriodIndex to be consistent with the others: dayofweek, dayofyear, etc.