BUG: drop_duplicates drops name(s). #10367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
added
Bug
Indexing
sinhrks
force-pushed
the
drop_duplicates_names
branch
3 times, most recently
from
35f10ab to
acddfaa
Compare
sinhrks
force-pushed
the
drop_duplicates_names
branch
from
acddfaa to
60a6e9f
Compare
| self.assertIsNone(idx_dup.freq) # freq is reset | ||
| result = idx_dup.drop_duplicates() | ||
| self.assert_index_equal(idx, result) | ||
| self.assertIsNone(result.freq) |
There was a problem hiding this comment.
hmm I think that these tests are in test_index.py (there is of course some duplication, pardon the pun, with where tests live for these sub-classes).
There was a problem hiding this comment.
I intended these tests are for freq rather than name, because name are tested in test_index. Maybe assert_index_equal should check all metadata to simplify the test (I've once tried and found some tests / logics must be fixed).
|
lgtm. ideally let's try to group tests that work across ALL sub-classes in |
|
merge when ready |
sinhrks
added a commit
that referenced
this pull request
Jun 23, 2015
BUG: drop_duplicates drops name(s).
|
Thank for review:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10115. Closes #10116.
Based on @seth-p and @jreback 's fix, added tets for datetime-likes.