BUG: fix UnicodeEncodeError with to_sql and unicode column names (GH11431) #11432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jorisvandenbossche if you want to add some tests can do for 0.17.1 |
|
I was just looking at it! :-) |
jorisvandenbossche
force-pushed
the
sql-unicode-column
branch
from
58878af
to
99149d3
Compare
|
lgtm, just needs a whatsnew note. merge when ready. |
jorisvandenbossche
force-pushed
the
sql-unicode-column
branch
from
99149d3
to
3f41c26
Compare
jorisvandenbossche
force-pushed
the
sql-unicode-column
branch
from
3f41c26
to
edd79ef
Compare
jorisvandenbossche
added a commit
that referenced
this pull request
Nov 16, 2015
BUG: fix UnicodeEncodeError with to_sql and unicode column names (GH11431)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11431
Still have to add tests