Copy on write using weakrefs (part 2) #12036

Closed
wants to merge 14 commits into
from

Conversation

Projects
None yet
6 participants
@nickeubank
Contributor

nickeubank commented Jan 14, 2016

Continuation of #11500

@nickeubank

This comment has been minimized.

Show comment
Hide comment
@nickeubank

nickeubank Jan 20, 2016

Contributor

@shoyer @jreback Ballpark timeline on refactor? Like, >1.5 years?

If so, I think I'll set this aside.Trying to modify the DataFrame constructor just opened a huge can of worms I think it'd take a long time to work through.

Till the refactor, any interest in making SettingWithCopyWarning into an exception?

Contributor

nickeubank commented Jan 20, 2016

@shoyer @jreback Ballpark timeline on refactor? Like, >1.5 years?

If so, I think I'll set this aside.Trying to modify the DataFrame constructor just opened a huge can of worms I think it'd take a long time to work through.

Till the refactor, any interest in making SettingWithCopyWarning into an exception?

@wesm

This comment has been minimized.

Show comment
Hide comment
@wesm

wesm Jan 20, 2016

Member

I'd like to get it done in under a year; in combing through the codebase I've been making lists of things to do. It's a large effort but luckily we have a huge test suite to protect us and help keep the train on the rails. Will keep you posted

Member

wesm commented Jan 20, 2016

I'd like to get it done in under a year; in combing through the codebase I've been making lists of things to do. It's a large effort but luckily we have a huge test suite to protect us and help keep the train on the rails. Will keep you posted

@nickeubank

This comment has been minimized.

Show comment
Hide comment
@nickeubank

nickeubank Jan 20, 2016

Contributor

@wesm Great. Then will def set aside. :)

Contributor

nickeubank commented Jan 20, 2016

@wesm Great. Then will def set aside. :)

@nickeubank nickeubank closed this Jan 20, 2016

@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Jan 20, 2016

Contributor

@nickeubank thanks for all the effort / commentary tests. I think these will be useful in the refactor.

Contributor

jreback commented Jan 20, 2016

@nickeubank thanks for all the effort / commentary tests. I think these will be useful in the refactor.

@nickeubank

This comment has been minimized.

Show comment
Hide comment
@nickeubank

nickeubank Jan 20, 2016

Contributor

@jreback thanks for the guidance! If nothing else, I now know a lot more about how references work in Python! :)

Contributor

nickeubank commented Jan 20, 2016

@jreback thanks for the guidance! If nothing else, I now know a lot more about how references work in Python! :)

@TomAugspurger

This comment has been minimized.

Show comment
Hide comment
@TomAugspurger

TomAugspurger Jan 20, 2016

Contributor

@nickeubank If you want to apply that knowledge for some internet karma, this came up yesterday ;)

Contributor

TomAugspurger commented Jan 20, 2016

@nickeubank If you want to apply that knowledge for some internet karma, this came up yesterday ;)

@nickeubank

This comment has been minimized.

Show comment
Hide comment
@nickeubank

nickeubank Jan 20, 2016

Contributor

@TomAugspurger on it, thanks Tom.

Contributor

nickeubank commented Jan 20, 2016

@TomAugspurger on it, thanks Tom.

@pkch

This comment has been minimized.

Show comment
Hide comment
@pkch

pkch Sep 4, 2016

Is there an open issue for this? I found a bunch of issues related to this, but didn't see any open ones.

pkch commented Sep 4, 2016

Is there an open issue for this? I found a bunch of issues related to this, but didn't see any open ones.

@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Sep 4, 2016

Contributor

there are refeneced issues

Contributor

jreback commented Sep 4, 2016

there are refeneced issues

@shoyer

This comment has been minimized.

Show comment
Hide comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment