Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: Patch to_dense behaviour for sparse. #14686

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@gfyoung
Copy link
Member

commented Nov 18, 2016

Patches the following for to_dense:

  1. Fix SparseArray.to_dense documentation to refer to SparseArray and not SparseSeries.

  2. Deprecate the fill parameter in SparseArray.to_dense, as that parameter was not being respected.

  3. Deprecate the sparse_only parameter in SparseSeries.to_dense, as that parameter is inconsistent with the to_dense API we want, which is no parameters.

Closes #14647.

@jreback

This comment has been minimized.

Copy link
Contributor

commented Nov 18, 2016

lgtm

@jsexauer jsexauer referenced this pull request Nov 18, 2016

Open

DEPR: deprecations from prior versions #6581

0 of 94 tasks complete

@jreback jreback added this to the 0.20.0 milestone Nov 18, 2016

@jreback jreback changed the title BUG: Patch to_dense behaviour for sparse. DEPR: Patch to_dense behaviour for sparse. Nov 18, 2016

@codecov-io

This comment has been minimized.

Copy link

commented Nov 18, 2016

Current coverage is 85.21% (diff: 100%)

Merging #14686 into master will decrease coverage by <.01%

@@             master     #14686   diff @@
==========================================
  Files           143        143          
  Lines         50796      50800     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43285      43288     +3   
- Misses         7511       7512     +1   
  Partials          0          0          

Powered by Codecov. Last update 880de30...ad7da32

@gfyoung gfyoung force-pushed the forking-repos:to-dense-patch branch 5 times, most recently from 0c2f535 to 867fe23 Nov 18, 2016

BUG: Patch to_dense behaviour for sparse.
Patches the following for to_dense:

1) Fix SparseArray.to_dense documentation
to refer to SparseArray and not SparseSeries.

2) Deprecate the fill parameter in
SparseArray.to_dense, as that parameter was
not being respected.

3) Deprecate the sparse_only parameter in
SparseSeries.to_dense, as that parameter is
inconsistent with the to_dense API we want,
which is no parameters.

Closes gh-14647.

@gfyoung gfyoung force-pushed the forking-repos:to-dense-patch branch from 867fe23 to ad7da32 Nov 23, 2016

@jreback

This comment has been minimized.

Copy link
Contributor

commented Nov 23, 2016

lgtm. tough travis is not passing.

@gfyoung

This comment has been minimized.

Copy link
Member Author

commented Nov 23, 2016

@jreback : One of the build machines appears to have broke for a reason unrelated to this PR. Are you able to restart the build on your end?

@gfyoung

This comment has been minimized.

Copy link
Member Author

commented Nov 23, 2016

@jreback : Everything is passing. Ready to merge if there is nothing else.

@jreback

This comment has been minimized.

Copy link
Contributor

commented Nov 23, 2016

thanks!

@jreback jreback closed this in e4413c4 Nov 23, 2016

@gfyoung gfyoung deleted the forking-repos:to-dense-patch branch Nov 23, 2016

amolkahat added a commit to amolkahat/pandas that referenced this pull request Nov 26, 2016

DEPR: Patch to_dense behaviour for sparse.
Patches the following for `to_dense`:    1) Fix `SparseArray.to_dense`
documentation to refer to `SparseArray` and not `SparseSeries`.    2)
Deprecate the fill parameter in `SparseArray.to_dense`, as that
parameter was not being respected.    3) Deprecate the sparse_only
parameter in `SparseSeries.to_dense`, as that parameter is
inconsistent with the `to_dense` API we want, which is no parameters.
Closes pandas-dev#14647.

Author: gfyoung <gfyoung17@gmail.com>

Closes pandas-dev#14686 from gfyoung/to-dense-patch and squashes the following commits:

ad7da32 [gfyoung] BUG: Patch to_dense behaviour for sparse.

gfyoung added a commit to forking-repos/pandas that referenced this pull request Sep 30, 2018

DEPR/CLN: Clean up to_dense signature deprecations
Also deprecate `fill` in `.get_values` because its
parameter was being passed to `.to_dense`, which
no longer accepts the `fill` parameter.

xref pandas-devgh-14686.

@jreback jreback referenced this pull request Sep 30, 2018

Open

DEPR: deprecations log for removed issues #13777

135 of 135 tasks complete

gfyoung added a commit to forking-repos/pandas that referenced this pull request Oct 16, 2018

DEPR/CLN: Clean up to_dense signature deprecations
Also deprecate `fill` in `.get_values` because its
parameter was being passed to `.to_dense`, which
no longer accepts the `fill` parameter.

xref pandas-devgh-14686.

gfyoung added a commit to forking-repos/pandas that referenced this pull request Oct 18, 2018

DEPR/CLN: Clean up to_dense signature deprecations
Also deprecate `fill` in `.get_values` because its
parameter was being passed to `.to_dense`, which
no longer accepts the `fill` parameter.

xref pandas-devgh-14686.

gfyoung added a commit to forking-repos/pandas that referenced this pull request Oct 18, 2018

DEPR/CLN: Clean up to_dense signature deprecations
Also deprecate `fill` in `.get_values` because its
parameter was being passed to `.to_dense`, which
no longer accepts the `fill` parameter.

xref pandas-devgh-14686.

gfyoung added a commit to forking-repos/pandas that referenced this pull request Oct 18, 2018

DEPR/CLN: Clean up to_dense signature deprecations
Also deprecate `fill` in `.get_values` because its
parameter was being passed to `.to_dense`, which
no longer accepts the `fill` parameter.

xref pandas-devgh-14686.

jreback added a commit that referenced this pull request Oct 18, 2018

DEPR/CLN: Clean up to_dense signature deprecations (#22910)
Also deprecate `fill` in `.get_values` because its
parameter was being passed to `.to_dense`, which
no longer accepts the `fill` parameter.

xref gh-14686.

brute4s99 added a commit to brute4s99/pandas that referenced this pull request Nov 19, 2018

DEPR/CLN: Clean up to_dense signature deprecations (pandas-dev#22910)
Also deprecate `fill` in `.get_values` because its
parameter was being passed to `.to_dense`, which
no longer accepts the `fill` parameter.

xref pandas-devgh-14686.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.