BUG: show series length in repr when truncated (GH15962) #15974
Conversation
jorisvandenbossche
added
the
Output-Formatting
| footer += ("Name: %s" % series_name) if name is not None else "" | ||
|
|
||
| if self.length: | ||
| if (self.length is True or |
There was a problem hiding this comment.
should have a check on the valid values of this (even though the option actually vets this)
There was a problem hiding this comment.
Yeah, I actually misuse the length keyword here a bit, which is normally a True/False keyword, but by internally also passing 'truncate' to it (otherwise I had to create a new keyword show_dimensions, which would render length useless)
| self.assertEqual(getndots(strrepr), 3) | ||
|
|
||
| def test_show_dimensions(self): | ||
| s = Series(range(5)) |
|
lgtm. |
|
@jorisvandenbossche can you update |
Also follow the display.show_dimensions option.
jorisvandenbossche
force-pushed
the
series-repr-length
branch
from
9a7c017 to
9bcfd76
Compare
jorisvandenbossche
force-pushed
the
series-repr-length
branch
from
9bcfd76 to
daf01f7
Compare
Codecov Report
@@ Coverage Diff @@
## master #15974 +/- ##
==========================================
+ Coverage 90.99% 91% +<.01%
==========================================
Files 153 153
Lines 50481 50478 -3
==========================================
- Hits 45937 45935 -2
+ Misses 4544 4543 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #15974 +/- ##
==========================================
+ Coverage 90.99% 91% +<.01%
==========================================
Files 153 153
Lines 50481 50478 -3
==========================================
- Hits 45937 45935 -2
+ Misses 4544 4543 -1
Continue to review full report at Codecov.
|
Also follow the display.show_dimensions option.
git diff upstream/master --name-only -- '*.py' | flake8 --diff