Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: add shims for util + TST: test that we work in downstream packages #16250

Merged
merged 2 commits into from May 5, 2017

Conversation

@jreback
Copy link
Contributor

@jreback jreback commented May 5, 2017

No description provided.

@jreback jreback added the Testing label May 5, 2017
@jreback jreback added this to the 0.20.1 milestone May 5, 2017
@jreback
Copy link
Contributor Author

@jreback jreback commented May 5, 2017

should update to have at least an example for each one.

@jorisvandenbossche @TomAugspurger

@jreback jreback force-pushed the jreback:down branch 2 times, most recently from d6fe725 to 4ecf5b1 May 5, 2017
@jreback jreback modified the milestones: 0.20.0, 0.20.1 May 5, 2017
@codecov
Copy link

@codecov codecov bot commented May 5, 2017

Codecov Report

Merging #16250 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16250      +/-   ##
==========================================
+ Coverage   90.33%   90.33%   +<.01%     
==========================================
  Files         164      164              
  Lines       50890    50890              
==========================================
+ Hits        45972    45973       +1     
+ Misses       4918     4917       -1
Flag Coverage Δ
#multiple 88.12% <ø> (+0.01%) ⬆️
#single 40.3% <ø> (-0.1%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.58% <0%> (-0.1%) ⬇️
pandas/core/generic.py 91.94% <0%> (+0.21%) ⬆️
pandas/core/common.py 91.03% <0%> (+0.34%) ⬆️
pandas/_version.py 44.65% <0%> (+1.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a31c96d...de72be4. Read the comment docs.

@codecov
Copy link

@codecov codecov bot commented May 5, 2017

Codecov Report

Merging #16250 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16250      +/-   ##
==========================================
- Coverage   90.33%    90.3%   -0.04%     
==========================================
  Files         164      167       +3     
  Lines       50890    50907      +17     
==========================================
  Hits        45972    45972              
- Misses       4918     4935      +17
Flag Coverage Δ
#multiple 88.09% <0%> (-0.02%) ⬇️
#single 40.29% <0%> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/util/hashing.py 0% <0%> (ø)
pandas/util/decorators.py 0% <0%> (ø)
pandas/types/common.py 0% <0%> (ø)
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.58% <0%> (-0.1%) ⬇️
pandas/core/generic.py 91.94% <0%> (+0.21%) ⬆️
pandas/_version.py 44.65% <0%> (+1.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a31c96d...085375f. Read the comment docs.

@jreback jreback force-pushed the jreback:down branch 3 times, most recently from 8b8969e to 68a52b4 May 5, 2017
@jreback jreback modified the milestones: 0.20.0, 0.20.1 May 5, 2017
@jreback jreback force-pushed the jreback:down branch 2 times, most recently from dc0cdcb to 92d1873 May 5, 2017
"from pandas.util",
DeprecationWarning, stacklevel=3)

from pandas.util import cache_readonly # noqa

This comment has been minimized.

@jorisvandenbossche

jorisvandenbossche May 5, 2017
Member

I don't know of anybody using it, but maybe also Appender and Substition to be sure? (or import *)

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Looks good!

Nice to add such test

@TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented May 5, 2017

@jreback I'm taking care of the release note for this in my doc updates (will have a PR shortly).

@jreback
Copy link
Contributor Author

@jreback jreback commented May 5, 2017

thanks @TomAugspurger yeah will merge when this is fixed.

TomAugspurger added a commit to TomAugspurger/pandas that referenced this pull request May 5, 2017
- Moved whatsnew for 0.20.1 -> 0.20.2 (unreleased)
- Moved whatsnew for 0.20.0 -> 0.20.1 (releasing soon)
- Added release note for pandas-dev#16250
TomAugspurger added a commit to TomAugspurger/pandas that referenced this pull request May 5, 2017
- Moved whatsnew for 0.20.1 -> 0.20.2 (unreleased)
- Moved whatsnew for 0.20.0 -> 0.20.1 (releasing soon)
- Added release note for pandas-dev#16250
TomAugspurger added a commit to TomAugspurger/pandas that referenced this pull request May 5, 2017
- Moved whatsnew for 0.20.1 -> 0.20.2 (unreleased)
- Moved whatsnew for 0.20.0 -> 0.20.1 (releasing soon)
- Added release note for pandas-dev#16250
@TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented May 5, 2017

@jreback https://travis-ci.org/pandas-dev/pandas/jobs/229097977 failed. Does that error message make sense to you?

@jreback jreback force-pushed the jreback:down branch from 2b061dc to 544b639 May 5, 2017
@jreback
Copy link
Contributor Author

@jreback jreback commented May 5, 2017

@TomAugspurger still working on things.

@jreback
Copy link
Contributor Author

@jreback jreback commented May 5, 2017

turns out our build-test build was not actually testing the correct installation :<

@jreback
Copy link
Contributor Author

@jreback jreback commented May 5, 2017

lon it built correctly but still some issue
will investigate

@jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented May 5, 2017

This all passed. Good to merge then?

@TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented May 5, 2017

@jreback
Copy link
Contributor Author

@jreback jreback commented May 5, 2017

not yet

@jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented May 5, 2017

Ah, yes, I didn't look at the allowed failures...

@jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented May 5, 2017

But, it is only the setting up of the test build env, not the actual code changes? Those could already be merged?

@TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented May 5, 2017

Ah, yes I think so. Although, those tests will be skipped if the deps aren't around. Do we we have dask and geopandas anywhere else in the matrix?

@jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented May 5, 2017

we can test those two locally

@jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented May 5, 2017

I checked out this PR, and can confirm it fixed the geopandas import for me

@TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented May 5, 2017

@jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented May 5, 2017

@jreback OK to merge and fix the test later?
(I can also split off just the code changes to merge only that)

@jreback
Copy link
Contributor Author

@jreback jreback commented May 5, 2017

yes that is fine

@jorisvandenbossche jorisvandenbossche changed the title TST: test that we work in downstream packages DEPR: add shims for util + TST: test that we work in downstream packages May 5, 2017
@jorisvandenbossche jorisvandenbossche merged commit 1d17618 into pandas-dev:master May 5, 2017
4 of 5 checks passed
4 of 5 checks passed
codecov/patch 0% of diff hit (target 50%)
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 90.3% (target 82%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pcluo added a commit to pcluo/pandas that referenced this pull request May 22, 2017
* DOC: Updated release notes for 0.20.1

- Moved whatsnew for 0.20.1 -> 0.20.2 (unreleased)
- Moved whatsnew for 0.20.0 -> 0.20.1 (releasing soon)
- Added release note for pandas-dev#16250

* DOC: Move 0.20.1 to a note

* DOC: Simplify excel style example
pcluo added a commit to pcluo/pandas that referenced this pull request May 22, 2017
stangirala added a commit to stangirala/pandas that referenced this pull request Jun 11, 2017
* DOC: Updated release notes for 0.20.1

- Moved whatsnew for 0.20.1 -> 0.20.2 (unreleased)
- Moved whatsnew for 0.20.0 -> 0.20.1 (releasing soon)
- Added release note for pandas-dev#16250

* DOC: Move 0.20.1 to a note

* DOC: Simplify excel style example
stangirala added a commit to stangirala/pandas that referenced this pull request Jun 11, 2017
yarikoptic added a commit to neurodebian/pandas that referenced this pull request Jul 12, 2017
Version 0.20.1

* tag 'v0.20.1':
  RLS: v0.20.1
  DOC: update release notes (pandas-dev#16259)
  DEPR: add shims for util + TST: test that we work in downstream packages (pandas-dev#16250)
  DOC: some reviewing of the 0.20 whatsnew file (pandas-dev#16254)
  DOC: add read_gbq as top-level in api.rst (pandas-dev#16256)
  DOC: Updated release notes for 0.20.1 (pandas-dev#16251)
gfyoung added a commit to forking-repos/pandas that referenced this pull request Oct 27, 2018
Removes the following:

* pandas.types
* pandas.computation
* pandas.util.decorators

xref pandas-devgh-16157.
xref pandas-devgh-16250.
@jreback jreback mentioned this pull request Oct 27, 2018
242 of 242 tasks complete
gfyoung added a commit to forking-repos/pandas that referenced this pull request Oct 28, 2018
Removes the following:

* pandas.types
* pandas.computation
* pandas.util.decorators

xref pandas-devgh-16157.
xref pandas-devgh-16250.
jreback added a commit that referenced this pull request Oct 28, 2018
Removes the following:

* pandas.types
* pandas.computation
* pandas.util.decorators

xref gh-16157.
xref gh-16250.
tm9k1 added a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Removes the following:

* pandas.types
* pandas.computation
* pandas.util.decorators

xref pandas-devgh-16157.
xref pandas-devgh-16250.
Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Removes the following:

* pandas.types
* pandas.computation
* pandas.util.decorators

xref pandas-devgh-16157.
xref pandas-devgh-16250.
Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Removes the following:

* pandas.types
* pandas.computation
* pandas.util.decorators

xref pandas-devgh-16157.
xref pandas-devgh-16250.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants