DEPR: add shims for util + TST: test that we work in downstream packages #16250
Conversation
|
should update to have at least an example for each one. |
jreback
force-pushed the
jreback:down
branch
2 times, most recently
from
d6fe725
to
4ecf5b1
Codecov Report
@@ Coverage Diff @@
## master #16250 +/- ##
==========================================
+ Coverage 90.33% 90.33% +<.01%
==========================================
Files 164 164
Lines 50890 50890
==========================================
+ Hits 45972 45973 +1
+ Misses 4918 4917 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #16250 +/- ##
==========================================
- Coverage 90.33% 90.3% -0.04%
==========================================
Files 164 167 +3
Lines 50890 50907 +17
==========================================
Hits 45972 45972
- Misses 4918 4935 +17
Continue to review full report at Codecov.
|
jreback
force-pushed the
jreback:down
branch
3 times, most recently
from
8b8969e
to
68a52b4
jreback
force-pushed the
jreback:down
branch
2 times, most recently
from
dc0cdcb
to
92d1873
| "from pandas.util", | ||
| DeprecationWarning, stacklevel=3) | ||
|
|
||
| from pandas.util import cache_readonly # noqa |
jorisvandenbossche
May 5, 2017
Member
I don't know of anybody using it, but maybe also Appender and Substition to be sure? (or import *)
I don't know of anybody using it, but maybe also Appender and Substition to be sure? (or import *)
|
Looks good! Nice to add such test |
|
@jreback I'm taking care of the release note for this in my doc updates (will have a PR shortly). |
|
thanks @TomAugspurger yeah will merge when this is fixed. |
- Moved whatsnew for 0.20.1 -> 0.20.2 (unreleased) - Moved whatsnew for 0.20.0 -> 0.20.1 (releasing soon) - Added release note for pandas-dev#16250
- Moved whatsnew for 0.20.1 -> 0.20.2 (unreleased) - Moved whatsnew for 0.20.0 -> 0.20.1 (releasing soon) - Added release note for pandas-dev#16250
- Moved whatsnew for 0.20.1 -> 0.20.2 (unreleased) - Moved whatsnew for 0.20.0 -> 0.20.1 (releasing soon) - Added release note for pandas-dev#16250
|
@jreback https://travis-ci.org/pandas-dev/pandas/jobs/229097977 failed. Does that error message make sense to you? |
|
@TomAugspurger still working on things. |
|
turns out our build-test build was not actually testing the correct installation :< |
|
lon it built correctly but still some issue |
|
This all passed. Good to merge then? |
|
The build one failed https://travis-ci.org/pandas-dev/pandas/jobs/229133755 |
|
not yet |
|
Ah, yes, I didn't look at the allowed failures... |
|
But, it is only the setting up of the test build env, not the actual code changes? Those could already be merged? |
|
Ah, yes I think so. Although, those tests will be skipped if the deps aren't around. Do we we have dask and geopandas anywhere else in the matrix? |
|
we can test those two locally |
|
I checked out this PR, and can confirm it fixed the geopandas import for me |
|
I think we're good then. I'll ensure they work after tagging but before
uploading.
…On Fri, May 5, 2017 at 11:13 AM, Joris Van den Bossche < ***@***.***> wrote:
I checked out this PR, and can confirm it fixed the geopandas import for me
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16250 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIiIeA89ll0o3pVss0hh10UU14noHks5r20qWgaJpZM4NRuiT>
.
|
|
@jreback OK to merge and fix the test later? |
|
yes that is fine |
jorisvandenbossche
changed the title
jorisvandenbossche
merged commit 1d17618
into
pandas-dev:master
* DOC: Updated release notes for 0.20.1 - Moved whatsnew for 0.20.1 -> 0.20.2 (unreleased) - Moved whatsnew for 0.20.0 -> 0.20.1 (releasing soon) - Added release note for pandas-dev#16250 * DOC: Move 0.20.1 to a note * DOC: Simplify excel style example
* DOC: Updated release notes for 0.20.1 - Moved whatsnew for 0.20.1 -> 0.20.2 (unreleased) - Moved whatsnew for 0.20.0 -> 0.20.1 (releasing soon) - Added release note for pandas-dev#16250 * DOC: Move 0.20.1 to a note * DOC: Simplify excel style example
Version 0.20.1 * tag 'v0.20.1': RLS: v0.20.1 DOC: update release notes (pandas-dev#16259) DEPR: add shims for util + TST: test that we work in downstream packages (pandas-dev#16250) DOC: some reviewing of the 0.20 whatsnew file (pandas-dev#16254) DOC: add read_gbq as top-level in api.rst (pandas-dev#16256) DOC: Updated release notes for 0.20.1 (pandas-dev#16251)
Verified
Removes the following: * pandas.types * pandas.computation * pandas.util.decorators xref pandas-devgh-16157. xref pandas-devgh-16250.
Verified
Removes the following: * pandas.types * pandas.computation * pandas.util.decorators xref pandas-devgh-16157. xref pandas-devgh-16250.
Removes the following: * pandas.types * pandas.computation * pandas.util.decorators xref pandas-devgh-16157. xref pandas-devgh-16250.
Removes the following: * pandas.types * pandas.computation * pandas.util.decorators xref pandas-devgh-16157. xref pandas-devgh-16250.
Removes the following: * pandas.types * pandas.computation * pandas.util.decorators xref pandas-devgh-16157. xref pandas-devgh-16250.
No description provided.