Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDEPR: add shims for util + TST: test that we work in downstream packages #16250
Conversation
jreback
added
the
Testing
label
May 5, 2017
jreback
added this to the 0.20.1 milestone
May 5, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
should update to have at least an example for each one. |
jreback
modified the milestones:
0.20.0,
0.20.1
May 5, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
codecov
bot
May 5, 2017
Codecov Report
Merging #16250 into master will increase coverage by
<.01%.
The diff coverage isn/a.
@@ Coverage Diff @@
## master #16250 +/- ##
==========================================
+ Coverage 90.33% 90.33% +<.01%
==========================================
Files 164 164
Lines 50890 50890
==========================================
+ Hits 45972 45973 +1
+ Misses 4918 4917 -1| Flag | Coverage Δ | |
|---|---|---|
| #multiple | 88.12% <ø> (+0.01%) |
|
| #single | 40.3% <ø> (-0.1%) |
| Impacted Files | Coverage Δ | |
|---|---|---|
| pandas/io/gbq.py | 25% <0%> (-58.34%) |
|
| pandas/core/frame.py | 97.58% <0%> (-0.1%) |
|
| pandas/core/generic.py | 91.94% <0%> (+0.21%) |
|
| pandas/core/common.py | 91.03% <0%> (+0.34%) |
|
| pandas/_version.py | 44.65% <0%> (+1.9%) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update a31c96d...de72be4. Read the comment docs.
codecov
bot
commented
May 5, 2017
Codecov Report
@@ Coverage Diff @@
## master #16250 +/- ##
==========================================
+ Coverage 90.33% 90.33% +<.01%
==========================================
Files 164 164
Lines 50890 50890
==========================================
+ Hits 45972 45973 +1
+ Misses 4918 4917 -1
Continue to review full report at Codecov.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
codecov
bot
May 5, 2017
Codecov Report
Merging #16250 into master will decrease coverage by
0.03%.
The diff coverage is0%.
@@ Coverage Diff @@
## master #16250 +/- ##
==========================================
- Coverage 90.33% 90.3% -0.04%
==========================================
Files 164 167 +3
Lines 50890 50907 +17
==========================================
Hits 45972 45972
- Misses 4918 4935 +17| Flag | Coverage Δ | |
|---|---|---|
| #multiple | 88.09% <0%> (-0.02%) |
|
| #single | 40.29% <0%> (-0.11%) |
| Impacted Files | Coverage Δ | |
|---|---|---|
| pandas/util/hashing.py | 0% <0%> (ø) |
|
| pandas/util/decorators.py | 0% <0%> (ø) |
|
| pandas/types/common.py | 0% <0%> (ø) |
|
| pandas/io/gbq.py | 25% <0%> (-58.34%) |
|
| pandas/core/frame.py | 97.58% <0%> (-0.1%) |
|
| pandas/core/generic.py | 91.94% <0%> (+0.21%) |
|
| pandas/_version.py | 44.65% <0%> (+1.9%) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update a31c96d...085375f. Read the comment docs.
codecov
bot
commented
May 5, 2017
•
edited
Edited 1 time
-
codecov bot
edited May 5, 2017 (most recent)
edited
-
May 5, 2017 (most recent)
Codecov Report
@@ Coverage Diff @@
## master #16250 +/- ##
==========================================
- Coverage 90.33% 90.3% -0.04%
==========================================
Files 164 167 +3
Lines 50890 50907 +17
==========================================
Hits 45972 45972
- Misses 4918 4935 +17
Continue to review full report at Codecov.
|
jreback
modified the milestones:
0.20.0,
0.20.1
May 5, 2017
| + "from pandas.util", | ||
| + DeprecationWarning, stacklevel=3) | ||
| + | ||
| +from pandas.util import cache_readonly # noqa |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jorisvandenbossche
May 5, 2017
Member
I don't know of anybody using it, but maybe also Appender and Substition to be sure? (or import *)
jorisvandenbossche
May 5, 2017
Member
I don't know of anybody using it, but maybe also Appender and Substition to be sure? (or import *)
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
TomAugspurger
May 5, 2017
Contributor
@jreback I'm taking care of the release note for this in my doc updates (will have a PR shortly).
|
@jreback I'm taking care of the release note for this in my doc updates (will have a PR shortly). |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
thanks @TomAugspurger yeah will merge when this is fixed. |
added a commit
to TomAugspurger/pandas
that referenced
this pull request
May 5, 2017
TomAugspurger
referenced this pull request
May 5, 2017
Merged
DOC: Updated release notes for 0.20.1 #16251
added a commit
to TomAugspurger/pandas
that referenced
this pull request
May 5, 2017
added a commit
to TomAugspurger/pandas
that referenced
this pull request
May 5, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
TomAugspurger
May 5, 2017
Contributor
@jreback https://travis-ci.org/pandas-dev/pandas/jobs/229097977 failed. Does that error message make sense to you?
|
@jreback https://travis-ci.org/pandas-dev/pandas/jobs/229097977 failed. Does that error message make sense to you? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@TomAugspurger still working on things. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jreback
May 5, 2017
Contributor
turns out our build-test build was not actually testing the correct installation :<
|
turns out our build-test build was not actually testing the correct installation :< |
jreback
added some commits
May 5, 2017
added a commit
that referenced
this pull request
May 5, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
lon it built correctly but still some issue |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
This all passed. Good to merge then? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
TomAugspurger
May 5, 2017
Contributor
The build one failed https://travis-ci.org/pandas-dev/pandas/jobs/229133755
|
The build one failed https://travis-ci.org/pandas-dev/pandas/jobs/229133755 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
not yet |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Ah, yes, I didn't look at the allowed failures... |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jorisvandenbossche
May 5, 2017
Member
But, it is only the setting up of the test build env, not the actual code changes? Those could already be merged?
|
But, it is only the setting up of the test build env, not the actual code changes? Those could already be merged? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
TomAugspurger
May 5, 2017
Contributor
Ah, yes I think so. Although, those tests will be skipped if the deps aren't around. Do we we have dask and geopandas anywhere else in the matrix?
|
Ah, yes I think so. Although, those tests will be skipped if the deps aren't around. Do we we have dask and geopandas anywhere else in the matrix? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
we can test those two locally |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jorisvandenbossche
May 5, 2017
Member
I checked out this PR, and can confirm it fixed the geopandas import for me
|
I checked out this PR, and can confirm it fixed the geopandas import for me |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
TomAugspurger
May 5, 2017
Contributor
|
I think we're good then. I'll ensure they work after tagging but before
uploading.
…On Fri, May 5, 2017 at 11:13 AM, Joris Van den Bossche < ***@***.***> wrote:
I checked out this PR, and can confirm it fixed the geopandas import for me
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16250 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIiIeA89ll0o3pVss0hh10UU14noHks5r20qWgaJpZM4NRuiT>
.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jorisvandenbossche
May 5, 2017
Member
@jreback OK to merge and fix the test later?
(I can also split off just the code changes to merge only that)
|
@jreback OK to merge and fix the test later? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
yes that is fine |
jorisvandenbossche
added
the
Deprecate
label
May 5, 2017
jorisvandenbossche
changed the title from
TST: test that we work in downstream packages
to
DEPR: add shims for util + TST: test that we work in downstream packages
May 5, 2017
jorisvandenbossche
merged commit 1d17618
into
pandas-dev:master
May 5, 2017
4 of 5 checks passed
added a commit
to pcluo/pandas
that referenced
this pull request
May 22, 2017
added a commit
to pcluo/pandas
that referenced
this pull request
May 22, 2017
added a commit
to stangirala/pandas
that referenced
this pull request
Jun 11, 2017
added a commit
to stangirala/pandas
that referenced
this pull request
Jun 11, 2017
added a commit
to neurodebian/pandas
that referenced
this pull request
Jul 12, 2017
jreback commentedMay 5, 2017
No description provided.