TST: Fix test assertions #16470
Merged
TST: Fix test assertions #16470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
stangirala
pushed a commit
to stangirala/pandas
that referenced
this pull request
Jun 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master --name-only -- '*.py' | flake8 --diffThis fixes some test assertions that were only checking the truthiness of a value when they should have been comparing two values. Initially, through typos, tests were written using assertTrue when they should have been using assertEqual. The second argument to assertTrue was being treated as a message instead of as the expected value. More recently, these assertions with typos were transformed to use
assert, with the same problems persisting.I have fixed each of the problems I found on a case-by-case basis. Some lines required more complicated fixes, like adding instanceof() or fixing an expected value. I believe I have found all such instances of this error, because I reviewed all the locations where assertTrue was called with two arguments.