Skip to content

Conversation

jbrockmendel
Copy link
Member

This is a piece of #17179, which is being broken up into smaller chunks.

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@gfyoung gfyoung added Clean Internals Related to non-user accessible pandas implementation labels Aug 30, 2017
@codecov
Copy link

codecov bot commented Aug 30, 2017

Codecov Report

Merging #17381 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17381      +/-   ##
==========================================
- Coverage   91.03%   91.02%   -0.02%     
==========================================
  Files         163      163              
  Lines       49570    49580      +10     
==========================================
  Hits        45128    45128              
- Misses       4442     4452      +10
Flag Coverage Δ
#multiple 88.8% <100%> (ø) ⬆️
#single 40.26% <100%> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/core/groupby.py 92.21% <100%> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.72% <0%> (-0.1%) ⬇️
pandas/core/indexes/base.py 95.84% <0%> (-0.04%) ⬇️
pandas/core/indexes/multi.py 96.9% <0%> (-0.03%) ⬇️
pandas/core/indexes/api.py 98.78% <0%> (ø) ⬆️
pandas/io/parsers.py 95.46% <0%> (ø) ⬆️
pandas/core/reshape/reshape.py 99.29% <0%> (ø) ⬆️
pandas/core/strings.py 98.46% <0%> (ø) ⬆️
pandas/core/sparse/scipy_sparse.py 97.05% <0%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad7d6fc...3a7a111. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 30, 2017

Codecov Report

Merging #17381 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17381      +/-   ##
==========================================
- Coverage   91.03%   91.02%   -0.02%     
==========================================
  Files         163      163              
  Lines       49570    49580      +10     
==========================================
  Hits        45128    45128              
- Misses       4442     4452      +10
Flag Coverage Δ
#multiple 88.8% <100%> (ø) ⬆️
#single 40.26% <100%> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/core/groupby.py 92.21% <100%> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.72% <0%> (-0.1%) ⬇️
pandas/core/indexes/base.py 95.84% <0%> (-0.04%) ⬇️
pandas/core/indexes/multi.py 96.9% <0%> (-0.03%) ⬇️
pandas/core/indexes/api.py 98.78% <0%> (ø) ⬆️
pandas/io/parsers.py 95.46% <0%> (ø) ⬆️
pandas/core/reshape/reshape.py 99.29% <0%> (ø) ⬆️
pandas/core/strings.py 98.46% <0%> (ø) ⬆️
pandas/core/sparse/scipy_sparse.py 97.05% <0%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad7d6fc...3a7a111. Read the comment docs.

@jreback jreback added this to the 0.21.0 milestone Aug 31, 2017
@jreback jreback merged commit 062f6f1 into pandas-dev:master Aug 31, 2017
@jreback
Copy link
Contributor

jreback commented Aug 31, 2017

thanks.

jowens pushed a commit to jowens/pandas that referenced this pull request Sep 20, 2017
@jbrockmendel jbrockmendel deleted the groupby_magic2 branch October 30, 2017 16:23
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Clean Internals Related to non-user accessible pandas implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants