Skip to content

Conversation

jbrockmendel
Copy link
Member

As a follow-up, this performs small touchups in a handful of places.

Implement .pxd file for tslibs.frequencies

cimport get_freq_code in period.pyx

Replace isinstance checks in period.pyx with C-equivalents form util

Remove unused imports from period.pyx

Remove code in tseries.frequencies that can now be imported from tslibs.frequencies

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Implement .pxd file for tslibs.frequencies

cimport get_freq_code in period.pyx

Replace isinstance checks in period.pyx with C-equivalents form util

Remove unused imports from period.pyx

Remove code in tseries.frequencies that can now be imported from tslibs.frequencies
@codecov
Copy link

codecov bot commented Sep 8, 2017

Codecov Report

Merging #17472 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17472      +/-   ##
==========================================
- Coverage   91.16%   91.13%   -0.03%     
==========================================
  Files         163      163              
  Lines       49561    49534      -27     
==========================================
- Hits        45180    45144      -36     
- Misses       4381     4390       +9
Flag Coverage Δ
#multiple 88.92% <100%> (-0.01%) ⬇️
#single 40.22% <100%> (-0.08%) ⬇️
Impacted Files Coverage Δ
pandas/tseries/frequencies.py 96.11% <100%> (-0.21%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.72% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4e8ac...b381895. Read the comment docs.

@jreback jreback added Clean Frequency DateOffsets Internals Related to non-user accessible pandas implementation Datetime Datetime data dtype labels Sep 8, 2017
@jreback jreback added this to the 0.21.0 milestone Sep 8, 2017
@jreback jreback merged commit d6df8ea into pandas-dev:master Sep 8, 2017
@jreback
Copy link
Contributor

jreback commented Sep 8, 2017

thanks

@jbrockmendel jbrockmendel deleted the tslibs-freqs branch October 30, 2017 16:25
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Clean Datetime Datetime data dtype Frequency DateOffsets Internals Related to non-user accessible pandas implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants