New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent UnicodeDecodeError in pivot_table under Py2 #17489

Merged
merged 5 commits into from Sep 12, 2017

Conversation

Projects
None yet
4 participants
@mpenkov
Contributor

mpenkov commented Sep 10, 2017

  • closes #13292
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry
@gfyoung

This comment has been minimized.

Show comment
Hide comment
@gfyoung

gfyoung Sep 10, 2017

Member

@mpenkov : Will need a whatsnew entry

Member

gfyoung commented Sep 10, 2017

@mpenkov : Will need a whatsnew entry

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 10, 2017

Codecov Report

Merging #17489 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17489      +/-   ##
==========================================
- Coverage   91.15%   91.14%   -0.02%     
==========================================
  Files         163      163              
  Lines       49534    49534              
==========================================
- Hits        45153    45148       -5     
- Misses       4381     4386       +5
Flag Coverage Δ
#multiple 88.92% <100%> (ø) ⬆️
#single 40.22% <50%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/reshape/pivot.py 96.35% <100%> (+0.99%) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.77% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23050dc...e851082. Read the comment docs.

codecov bot commented Sep 10, 2017

Codecov Report

Merging #17489 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17489      +/-   ##
==========================================
- Coverage   91.15%   91.14%   -0.02%     
==========================================
  Files         163      163              
  Lines       49534    49534              
==========================================
- Hits        45153    45148       -5     
- Misses       4381     4386       +5
Flag Coverage Δ
#multiple 88.92% <100%> (ø) ⬆️
#single 40.22% <50%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/reshape/pivot.py 96.35% <100%> (+0.99%) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.77% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23050dc...e851082. Read the comment docs.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 10, 2017

Codecov Report

Merging #17489 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17489      +/-   ##
==========================================
- Coverage   91.15%   91.14%   -0.02%     
==========================================
  Files         163      163              
  Lines       49534    49534              
==========================================
- Hits        45153    45148       -5     
- Misses       4381     4386       +5
Flag Coverage Δ
#multiple 88.92% <100%> (ø) ⬆️
#single 40.22% <0%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/reshape/pivot.py 96.35% <100%> (+0.99%) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.77% <0%> (-0.05%) ⬇️
pandas/io/feather_format.py 85.71% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23050dc...ce96abd. Read the comment docs.

codecov bot commented Sep 10, 2017

Codecov Report

Merging #17489 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17489      +/-   ##
==========================================
- Coverage   91.15%   91.14%   -0.02%     
==========================================
  Files         163      163              
  Lines       49534    49534              
==========================================
- Hits        45153    45148       -5     
- Misses       4381     4386       +5
Flag Coverage Δ
#multiple 88.92% <100%> (ø) ⬆️
#single 40.22% <0%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/reshape/pivot.py 96.35% <100%> (+0.99%) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.77% <0%> (-0.05%) ⬇️
pandas/io/feather_format.py 85.71% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23050dc...ce96abd. Read the comment docs.

@mpenkov

This comment has been minimized.

Show comment
Hide comment
@mpenkov

mpenkov Sep 10, 2017

Contributor

@gfyoung Added the what's new. Please check.

Contributor

mpenkov commented Sep 10, 2017

@gfyoung Added the what's new. Please check.

Show outdated Hide outdated pandas/tests/reshape/test_pivot.py
Show outdated Hide outdated pandas/tests/reshape/test_pivot.py
Show outdated Hide outdated doc/source/whatsnew/v0.20.0.txt

@jreback jreback added this to the 0.21.0 milestone Sep 12, 2017

@jreback jreback merged commit d46b027 into pandas-dev:master Sep 12, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Sep 12, 2017

Contributor

thanks @mpenkov

Contributor

jreback commented Sep 12, 2017

thanks @mpenkov

mpenkov referenced this pull request in mpenkov/pandas Oct 23, 2017

alanbato added a commit to alanbato/pandas that referenced this pull request Nov 10, 2017

No-Stream added a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment