Skip to content

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Sep 26, 2017

closes #17674

@jreback jreback added Compat pandas objects compatability with Numpy or Python functions Deprecate Functionality to remove in pandas labels Sep 26, 2017
@jreback jreback added this to the 0.21.0 milestone Sep 26, 2017
@jreback
Copy link
Contributor Author

jreback commented Sep 26, 2017

@TomAugspurger I think this works, pls give a check.

Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out, looks good.

@codecov
Copy link

codecov bot commented Sep 26, 2017

Codecov Report

Merging #17683 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17683      +/-   ##
==========================================
- Coverage   91.25%   91.22%   -0.04%     
==========================================
  Files         163      163              
  Lines       49736    49737       +1     
==========================================
- Hits        45389    45372      -17     
- Misses       4347     4365      +18
Flag Coverage Δ
#multiple 89.01% <100%> (-0.02%) ⬇️
#single 40.34% <83.33%> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/core/categorical.py 95.69% <100%> (+0.41%) ⬆️
pandas/core/accessor.py 93.75% <100%> (+0.09%) ⬆️
pandas/core/generic.py 92.07% <100%> (ø) ⬆️
pandas/core/series.py 94.93% <100%> (ø) ⬆️
pandas/core/frame.py 97.73% <100%> (-0.1%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/plotting/_converter.py 63.38% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e87385...3946c83. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 26, 2017

Codecov Report

Merging #17683 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17683      +/-   ##
==========================================
- Coverage   91.25%   91.22%   -0.04%     
==========================================
  Files         163      163              
  Lines       49736    49737       +1     
==========================================
- Hits        45389    45372      -17     
- Misses       4347     4365      +18
Flag Coverage Δ
#multiple 89.01% <100%> (-0.02%) ⬇️
#single 40.34% <83.33%> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/core/generic.py 92.07% <100%> (ø) ⬆️
pandas/core/accessor.py 93.75% <100%> (+0.09%) ⬆️
pandas/core/frame.py 97.73% <100%> (-0.1%) ⬇️
pandas/core/categorical.py 95.69% <100%> (+0.41%) ⬆️
pandas/core/series.py 94.93% <100%> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/plotting/_converter.py 63.38% <0%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e87385...3946c83. Read the comment docs.

@TomAugspurger TomAugspurger merged commit 66f4cc1 into pandas-dev:master Sep 26, 2017
alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compat pandas objects compatability with Numpy or Python functions Deprecate Functionality to remove in pandas

Projects

None yet

Development

Successfully merging this pull request may close these issues.

as_block depr warning on tab completion

3 participants