console_encode() fails on unicode when using ipython-notebook #1782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
Thanks for looking into this. I'll take the first commit but won't take the latter without a unit test |
|
72d014a breaks python 2. Will have to look into it another time |
|
how do I reproduce the problem on python 2? |
|
The unit test suite fails on python2 |
|
Added a unit test and a guard so that things behave properly when series.name is test_series and test_format pass over here. |
|
Thanks. cherry-picked these |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in ipnb (linux) I get:
I traced this back to sys.stdin.encoding being set to None rather then 'utf-8' like in the shell.
Attached is a fix for your consideration. the test is just a stub since mocking is required
to reproduce the bug when testing in the shell instead of inside ipnb.