Skip to content

Conversation

jbrockmendel
Copy link
Member

This replaces uses of pandas_datetime_to_datetimestruct and pandas_datetimestruct_to_datetime with dt64_to_dtstruct and dtstruct_to_dt64 respectively, but leaves some un-replaced to avoid creating conflicts with other open PRs.

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback jreback added Internals Related to non-user accessible pandas implementation Datetime Datetime data dtype labels Oct 29, 2017
@jreback
Copy link
Contributor

jreback commented Oct 29, 2017

looks fine. ping when green.

@codecov
Copy link

codecov bot commented Oct 29, 2017

Codecov Report

Merging #18023 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18023      +/-   ##
==========================================
- Coverage   91.26%   91.24%   -0.02%     
==========================================
  Files         163      163              
  Lines       50099    50099              
==========================================
- Hits        45724    45715       -9     
- Misses       4375     4384       +9
Flag Coverage Δ
#multiple 89.05% <ø> (ø) ⬆️
#single 40.24% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a355ed2...04dd69d. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 29, 2017

Codecov Report

Merging #18023 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18023      +/-   ##
==========================================
- Coverage   91.26%   91.24%   -0.02%     
==========================================
  Files         163      163              
  Lines       50099    50099              
==========================================
- Hits        45724    45715       -9     
- Misses       4375     4384       +9
Flag Coverage Δ
#multiple 89.05% <ø> (ø) ⬆️
#single 40.24% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a355ed2...04dd69d. Read the comment docs.

@jbrockmendel
Copy link
Member Author

ping

@jreback jreback merged commit 4af9a8b into pandas-dev:master Oct 29, 2017
@jreback
Copy link
Contributor

jreback commented Oct 29, 2017

thanks

i assume u have a note to change the remaining on tslib at some point

@jbrockmendel jbrockmendel deleted the tslibs-depends branch October 30, 2017 16:25
peterpanmj pushed a commit to peterpanmj/pandas that referenced this pull request Oct 31, 2017
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Datetime Datetime data dtype Internals Related to non-user accessible pandas implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants