New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Let CategoricalIndex take CategoricalDtype as dtype argument #18116

Merged
merged 1 commit into from Nov 5, 2017

Conversation

Projects
None yet
3 participants
@topper-123
Contributor

topper-123 commented Nov 4, 2017

  • [x ] closes #18109
  • [x ] tests added / passed
  • [ x] passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • [ x] whatsnew entry

This PR allows CategoricalIndex to take CategoricalDtype as its dtype argument, see #18109 for details.

@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Nov 4, 2017

Contributor

lgtm. can you add a release note, 0.21.1 is good.

Contributor

jreback commented Nov 4, 2017

lgtm. can you add a release note, 0.21.1 is good.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 5, 2017

Codecov Report

Merging #18116 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18116      +/-   ##
==========================================
+ Coverage   91.25%   91.26%   +<.01%     
==========================================
  Files         163      163              
  Lines       50124    50124              
==========================================
+ Hits        45742    45745       +3     
+ Misses       4382     4379       -3
Flag Coverage Δ
#multiple 89.07% <100%> (+0.02%) ⬆️
#single 40.32% <100%> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/category.py 97.46% <100%> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.2% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8388a47...016f08c. Read the comment docs.

codecov bot commented Nov 5, 2017

Codecov Report

Merging #18116 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18116      +/-   ##
==========================================
+ Coverage   91.25%   91.26%   +<.01%     
==========================================
  Files         163      163              
  Lines       50124    50124              
==========================================
+ Hits        45742    45745       +3     
+ Misses       4382     4379       -3
Flag Coverage Δ
#multiple 89.07% <100%> (+0.02%) ⬆️
#single 40.32% <100%> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/category.py 97.46% <100%> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.2% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8388a47...016f08c. Read the comment docs.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 5, 2017

Codecov Report

Merging #18116 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18116      +/-   ##
==========================================
+ Coverage   91.25%   91.26%   +<.01%     
==========================================
  Files         163      163              
  Lines       50124    50124              
==========================================
+ Hits        45742    45745       +3     
+ Misses       4382     4379       -3
Flag Coverage Δ
#multiple 89.07% <100%> (+0.02%) ⬆️
#single 40.32% <100%> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/category.py 97.46% <100%> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.2% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8388a47...016f08c. Read the comment docs.

codecov bot commented Nov 5, 2017

Codecov Report

Merging #18116 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18116      +/-   ##
==========================================
+ Coverage   91.25%   91.26%   +<.01%     
==========================================
  Files         163      163              
  Lines       50124    50124              
==========================================
+ Hits        45742    45745       +3     
+ Misses       4382     4379       -3
Flag Coverage Δ
#multiple 89.07% <100%> (+0.02%) ⬆️
#single 40.32% <100%> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/category.py 97.46% <100%> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.75% <0%> (-0.1%) ⬇️
pandas/plotting/_converter.py 65.2% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8388a47...016f08c. Read the comment docs.

@topper-123

This comment has been minimized.

Show comment
Hide comment
@topper-123

topper-123 Nov 5, 2017

Contributor

Pinging at green @jreback.

Contributor

topper-123 commented Nov 5, 2017

Pinging at green @jreback.

@jreback jreback added this to the 0.21.1 milestone Nov 5, 2017

@jreback jreback merged commit 58c2f09 into pandas-dev:master Nov 5, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Nov 5, 2017

Contributor

thanks!

Contributor

jreback commented Nov 5, 2017

thanks!

@topper-123 topper-123 deleted the topper-123:CategoricalIndex_dtype branch Nov 5, 2017

No-Stream added a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017

TomAugspurger added a commit to TomAugspurger/pandas that referenced this pull request Dec 8, 2017

TomAugspurger added a commit that referenced this pull request Dec 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment