Skip to content

Conversation

TomAugspurger
Copy link
Contributor

Added strict flag to catch this in the future

xref #18427 (comment)

Added strict flag to catch this in the future
@gfyoung gfyoung added the Testing pandas testing functions or related to the test suite label Nov 27, 2017
@jreback jreback added this to the 0.22.0 milestone Nov 27, 2017
@codecov
Copy link

codecov bot commented Nov 27, 2017

Codecov Report

Merging #18526 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18526      +/-   ##
==========================================
- Coverage   91.35%   91.33%   -0.03%     
==========================================
  Files         164      164              
  Lines       49819    49801      -18     
==========================================
- Hits        45512    45485      -27     
- Misses       4307     4316       +9
Flag Coverage Δ
#multiple 89.13% <ø> (-0.01%) ⬇️
#single 40.81% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️
pandas/tseries/offsets.py 96.9% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34b036c...63a338b. Read the comment docs.

@jreback jreback merged commit 6148e58 into pandas-dev:master Nov 28, 2017
@jreback
Copy link
Contributor

jreback commented Nov 28, 2017

thanks @TomAugspurger

@TomAugspurger TomAugspurger deleted the converter branch December 20, 2017 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants