Skip to content

Conversation

jorisvandenbossche
Copy link
Member

No description provided.

@jorisvandenbossche jorisvandenbossche added the Testing pandas testing functions or related to the test suite label Dec 10, 2017
@jorisvandenbossche jorisvandenbossche added this to the 0.22.0 milestone Dec 10, 2017
@jreback
Copy link
Contributor

jreback commented Dec 10, 2017

a couple more

pandas/tests/io/conftest.py:import moto
pandas/tests/io/conftest.py:    moto.mock_s3().start()
pandas/tests/io/conftest.py:    moto.mock_s3().stop()
pandas/tests/io/json/test_compression.py:import moto
pandas/tests/io/json/test_compression.py:    with moto.mock_s3():
pandas/tests/io/test_excel.py:import moto
pandas/tests/io/test_excel.py:        with moto.mock_s3():

@jorisvandenbossche
Copy link
Member Author

ah, yes, the difference is that this one is in a conftest, and so then even if you run some specific tests (not related to tests that use moto), it still tries to import it because it is in a conftest.py.

But will fix the others as well.

@codecov
Copy link

codecov bot commented Dec 11, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@b8b108c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #18719   +/-   ##
=========================================
  Coverage          ?    91.6%           
=========================================
  Files             ?      153           
  Lines             ?    51306           
  Branches          ?        0           
=========================================
  Hits              ?    46999           
  Misses            ?     4307           
  Partials          ?        0
Flag Coverage Δ
#multiple 89.46% <ø> (?)
#single 40.72% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8b108c...cdf82ac. Read the comment docs.

@jreback jreback merged commit c753e1e into pandas-dev:master Dec 11, 2017
@jreback
Copy link
Contributor

jreback commented Dec 11, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants