Skip to content

Conversation

jbrockmendel
Copy link
Member

No luck so far in tracking down the issue where this was discussed.

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jreback jreback added Clean Internals Related to non-user accessible pandas implementation labels Jan 11, 2018
@jreback jreback added this to the 0.23.0 milestone Jan 11, 2018
@codecov
Copy link

codecov bot commented Jan 11, 2018

Codecov Report

Merging #19180 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19180      +/-   ##
==========================================
+ Coverage   91.52%   91.52%   +<.01%     
==========================================
  Files         147      148       +1     
  Lines       48775    48776       +1     
==========================================
+ Hits        44639    44642       +3     
+ Misses       4136     4134       -2
Flag Coverage Δ
#multiple 89.89% <100%> (ø) ⬆️
#single 41.61% <100%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/internals.py 94.49% <100%> (+0.06%) ⬆️
pandas/core/dtypes/cast.py 88.42% <0%> (-0.16%) ⬇️
pandas/tools/hashing.py 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8acdf80...d27bcc5. Read the comment docs.

@jbrockmendel
Copy link
Member Author

CI has been on the fritz for a few days. Should I keep trying or wait until further notice?

@jreback jreback merged commit 78c3ff9 into pandas-dev:master Jan 12, 2018
@jreback
Copy link
Contributor

jreback commented Jan 12, 2018

this is fine. generally if the CI fails for an othogonal reason to the PR don't keep pushing.

@jbrockmendel jbrockmendel deleted the internalize branch February 11, 2018 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Clean Internals Related to non-user accessible pandas implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants