New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERR: raise KeyError on invalid column name in aggregate #19566

Merged
merged 1 commit into from Feb 7, 2018

Conversation

Projects
None yet
2 participants
@jreback
Contributor

jreback commented Feb 7, 2018

@jreback jreback added this to the 0.23.0 milestone Feb 7, 2018

@jreback

This comment has been minimized.

Contributor

jreback commented Feb 7, 2018

cc @discort

@@ -647,7 +647,7 @@ Groupby/Resample/Rolling
- Bug in :func:`DataFrame.groupby` where aggregation by ``first``/``last``/``min``/``max`` was causing timestamps to lose precision (:issue:`19526`)
- Bug in :func:`DataFrame.transform` where particular aggregation functions were being incorrectly cast to match the dtype(s) of the grouped data (:issue:`19200`)
- Bug in :func:`DataFrame.groupby` passing the `on=` kwarg, and subsequently using ``.apply()`` (:issue:`17813`)
- Bug in :func:`DataFrame.resample().aggregate` not raising a `ValueError` when aggregating a non-existent column (:issue:`16766`)
- Bug in :func:`DataFrame.resample().aggregate` not raising a ``ValueError`` when aggregating a non-existent column (:issue:`16766`, :issue:`19566`)

This comment has been minimized.

@discort

discort Feb 7, 2018

Contributor

@jreback

Didn't you forget to replace ValueError by KeyError at this line?

This comment has been minimized.

@jreback

jreback Feb 7, 2018

Contributor

shoot yeah must not have committed
thanks

@jreback jreback merged commit 4e1fcba into pandas-dev:master Feb 7, 2018

0 of 3 checks passed

ci/circleci Your tests are queued behind your running builds
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment